Skip to content

[JENKINS-74056] Extract JS in PipelineHeaderExtension/columnHeader.jelly - #148

Open
shlomomdahan wants to merge 11 commits into
jenkinsci:masterfrom
shlomomdahan:JENKINS-74056
Open

[JENKINS-74056] Extract JS in PipelineHeaderExtension/columnHeader.jelly#148
shlomomdahan wants to merge 11 commits into
jenkinsci:masterfrom
shlomomdahan:JENKINS-74056

Conversation

@shlomomdahan

@shlomomdahan shlomomdahan commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

JENKINS-74056

Similar Extraction - used as reference

To test:

  1. Create a pipeline similar to [JENKINS-73960] Extract event handlers in BuildCardExtension/buildCardTemplate.jelly #142
  2. In the pipeline configuration settings, use the below setting to reveal the column Header cards.
    Screenshot 2024-10-31 at 2 44 12 PM

You should see the cards above the pipeline:
Screenshot 2024-10-31 at 2 44 35 PM

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@shlomomdahan
shlomomdahan requested a review from a team as a code owner October 31, 2024 18:45
@shlomomdahan shlomomdahan mentioned this pull request Nov 4, 2024
6 tasks
@basil

basil commented Nov 8, 2024

Copy link
Copy Markdown
Member

Can we split the negative ID bugfix into a separate PR so that I can review that independently of the CSP changes?

@shlomomdahan

Copy link
Copy Markdown
Contributor Author

@basil

PR for negative ID bugfix created: #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants