Skip to content

fix(skills): restore _send_feedback alias for pre-#542 workspace skills #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theo-michel merged 1 commit into from
Aug 8, 2026
Merged

fix(skills): restore _send_feedback alias for pre-#542 workspace skills #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ros2_ws/src/brain/brain_client/brain_client/skills/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1103,6 +1103,10 @@ def feedback(self, message: str, image_b64: str | None = None) -> None:
except Exception as e:
self.logger.error(f"Error sending feedback for skill {self.name}: {e}")

def _send_feedback(self, message: str, image_b64: str | None = None) -> None:
"""Deprecated pre-#542 name for feedback(), kept for existing workspace skills."""
self.feedback(message, image_b64)

def set_feedback_callback(self, callback: Callable[[str, str | None], None]) -> None:
self._feedback_callback = callback
self.logger.debug(f"Feedback callback set for skill {self.name}.")
Loading