fix(skills): restore _send_feedback alias for pre-#542 workspace skills - #629
Merged
Conversation
#542 renamed Skill._send_feedback to feedback(); existing workspace skills still call the old name and crash with AttributeError. Keep a thin deprecated alias so user code keeps working.
Contributor
Greptile SummaryRestores backward compatibility for user-authored workspace skills created before #542.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The restored method accepts the same arguments as the legacy API and delegates directly to the existing behavior-equivalent feedback implementation. Important Files Changed
Reviews (1): Last reviewed commit: "fix(skills): restore _send_feedback alia..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#542 renamed
Skill._send_feedback(message, image_b64)tofeedback(message, image_b64). Workspace skills are user code living outside the repo, so any skill written before #542 still calls the old name and now crashes withAttributeErrorthe first time it sends feedback.Fix
A thin deprecated alias on the
Skillbase class:_send_feedback()delegates tofeedback(). Signatures are identical, so old skills work unchanged; new skills keep usingself.feedback().Verification
ruff checkandruff format --checkclean onbrain_client/