Skip to content

fix(skills): restore _send_feedback alias for pre-#542 workspace skills - #629

Merged
theo-michel merged 1 commit into
mainfrom
fix/send-feedback-compat
Aug 8, 2026
Merged

fix(skills): restore _send_feedback alias for pre-#542 workspace skills#629
theo-michel merged 1 commit into
mainfrom
fix/send-feedback-compat

Conversation

@theo-michel

Copy link
Copy Markdown
Contributor

Problem

#542 renamed Skill._send_feedback(message, image_b64) to feedback(message, image_b64). Workspace skills are user code living outside the repo, so any skill written before #542 still calls the old name and now crashes with AttributeError the first time it sends feedback.

Fix

A thin deprecated alias on the Skill base class: _send_feedback() delegates to feedback(). Signatures are identical, so old skills work unchanged; new skills keep using self.feedback().

Verification

  • ruff check and ruff format --check clean on brain_client/
  • 222/222 brain_client tests pass
  • basedpyright reports no errors in the touched file (13 pre-existing errors elsewhere from basedpyright 1.39.9 being newer than the last-pinned run — none related to this change)

#542 renamed Skill._send_feedback to feedback(); existing workspace
skills still call the old name and crash with AttributeError. Keep a
thin deprecated alias so user code keeps working.
@greptile-apps

greptile-apps Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Restores backward compatibility for user-authored workspace skills created before #542.

  • Adds a deprecated Skill._send_feedback() alias.
  • Delegates feedback messages and optional images directly to Skill.feedback().

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The restored method accepts the same arguments as the legacy API and delegates directly to the existing behavior-equivalent feedback implementation.

Important Files Changed

Filename Overview
ros2_ws/src/brain/brain_client/brain_client/skills/types.py Adds a signature-compatible deprecated alias that preserves the previous feedback behavior without changing the current API.

Reviews (1): Last reviewed commit: "fix(skills): restore _send_feedback alia..." | Re-trigger Greptile

@DavidDobas DavidDobas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theo-michel
theo-michel merged commit d401639 into main Aug 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants