Skip to content

fix(ui-voice): start large model pack files first and show verification progress (v0.3) #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leeroybrun merged 5 commits into from
Oct 20, 2026
+12 −9
Merged

fix(ui-voice): start large model pack files first and show verification progress (v0.3) #620

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6040058
fix(voice): show model pack verification and start large files first
danljungstrom Oct 19, 2026
6d1942f
fix(voice): keep model pack verification progress from sliding back o…
danljungstrom Oct 19, 2026
92c77f5
fix(voice): preserve verification progress through native preparation
leeroybrun Oct 20, 2026
38f3233
fix(voice): restart verification when a server ignores Range
leeroybrun Oct 20, 2026
a771c5a
chore(voice): merge v0.3 and preserve verification reset
leeroybrun Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions packages/voice-modelpacks/src/installerCore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,8 @@ async function downloadFileResumable(opts: {
signal: AbortSignal;
/** `verifiedForFile` is set once bytes are hashed; a restarted pass reports it from 0 again. */
onFileProgress: (loadedForFile: number, verifiedForFile?: number) => void;
/** Previously reported existing bytes were discarded and must no longer contribute to progress. */
onExistingRejected: () => void;
/** Withdraw discarded file bytes, or only hash progress when a full response replaces a Range prefix. */
onProgressReset: (scope: 'file' | 'verification') => void;
urlPolicy?: ModelPackUrlPolicy;
transferUrl?: string;
}): Promise<void> {
Expand Down Expand Up @@ -330,7 +330,7 @@ async function downloadFileResumable(opts: {
throwIfAborted(signal);
if (reported !== streamed || streamed !== existing) {
await staging.resetPartial(entry.path);
opts.onExistingRejected();
opts.onProgressReset('file');
return downloadFileResumable({ ...opts, onFileProgress: opts.onFileProgress });
} else {
loaded = streamed;
Expand All @@ -339,7 +339,7 @@ async function downloadFileResumable(opts: {
// Cancelling verification does not invalidate the existing resumable prefix.
throwIfAborted(signal);
await staging.resetPartial(entry.path);
opts.onExistingRejected();
opts.onProgressReset('file');
if (error instanceof ModelPackInstallError) {
throw error;
}
Expand All @@ -348,7 +348,7 @@ async function downloadFileResumable(opts: {
} else if (existing > expectedSize) {
// Corrupt/overlong partial — start over.
await staging.resetPartial(entry.path);
opts.onExistingRejected();
opts.onProgressReset('file');
}

// Already complete? Verify hash and skip the network entirely.
Expand All @@ -358,7 +358,7 @@ async function downloadFileResumable(opts: {
return;
}
await staging.resetPartial(entry.path);
opts.onExistingRejected();
opts.onProgressReset('file');
// Fall through to a clean re-download.
return downloadFileResumable({ ...opts, onFileProgress: opts.onFileProgress });
}
Expand All @@ -384,6 +384,7 @@ async function downloadFileResumable(opts: {
await staging.resetPartial(entry.path);
loaded = 0;
hasher = host.createHasher();
opts.onProgressReset('verification');
}

await consumeStream({
Expand Down Expand Up @@ -546,10 +547,12 @@ export async function installModelPackWithHost(opts: {
}
await downloadFileResumable({
host: opts.host, packId, staging, entry, signal: pack.signal, urlPolicy: opts.urlPolicy, transferUrl,
onExistingRejected: () => {
loadedTotal -= loadedThisFile;
onProgressReset: (scope) => {
if (scope === 'file') {
loadedTotal -= loadedThisFile;
loadedThisFile = 0;
}
verifiedTotal -= verifiedThisFile;
loadedThisFile = 0;
verifiedThisFile = 0;
report(entry.path);
},
Expand Down
Loading