Skip to content

gen_merged_protos : add new project root parameter to allow merging protos from custom paths #6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dragosp95 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gen_merged_protos : add new project root parameter to allow merging protos from custom paths #6919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions tools/gen_merged_protos
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,29 @@
from __future__ import absolute_import
from __future__ import division
from __future__ import print_function
import argparse
import os
import re
import sys
from codecs import open

PROJECT_ROOT = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
SELF_PATH = os.path.relpath(__file__, PROJECT_ROOT).replace('\\', '/')
DEFAULT_PROJECT_ROOT = os.path.dirname(
os.path.dirname(os.path.realpath(__file__)))

parser = argparse.ArgumentParser(
description='Merge all Perfetto protos into a single file.')
parser.add_argument(
'--project-root',
default=DEFAULT_PROJECT_ROOT,
help='Path to the protos project root directory.')
parser.add_argument(
'--check-only',
action='store_true',
help='Check if merged protos are up to date without modifying them.')
args, unknown_args = parser.parse_known_args()

@sashwinbalaji sashwinbalaji Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just do args = parser.parse_args() safer than discarding unknwon ones ?


PROJECT_ROOT = os.path.abspath(args.project_root)
SELF_PATH = os.path.relpath(__file__, DEFAULT_PROJECT_ROOT).replace('\\', '/')

CONFIG_PROTO_ROOTS = [
'protos/perfetto/common/data_source_descriptor.proto',
Expand Down Expand Up @@ -137,7 +153,7 @@ def merge_protos(root_paths, output_path):
if prev_content == merged_content:
return True

if '--check-only' in sys.argv:
if args.check_only:
return False

print('Updating {}'.format(output_path))
Expand Down