gen_merged_protos : add new project root parameter to allow merging protos from custom paths - #6919
Open
dragosp95 wants to merge 1 commit into
Open
gen_merged_protos : add new project root parameter to allow merging protos from custom paths#6919dragosp95 wants to merge 1 commit into
dragosp95 wants to merge 1 commit into
Conversation
dragosp95
force-pushed
the
dev/dragosp/merge-protos-in-custom-path
branch
from
July 29, 2026 14:24
e107200 to
9233bbe
Compare
dragosp95
changed the title
| '--check-only', | ||
| action='store_true', | ||
| help='Check if merged protos are up to date without modifying them.') | ||
| args, unknown_args = parser.parse_known_args() |
Member
There was a problem hiding this comment.
should we just do args = parser.parse_args() safer than discarding unknwon ones ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new project root parameter in tools/gen_merged_protos to allow merging protos from custom paths.
This will be used for dynamically merging copies of perfetto files.
This change will not change the default behaviour.