feat(gitea): accept optional ports in instance hostnames - #3344
Merged
Merged
Conversation
Use forge-specific hostname validation for login, saved accounts, and API requests while retaining HTTPS and host-plus-port origin checks. Closes #3323
github-actions
Bot
added
enhancement
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gitea and Forgejo instances such as
gitea.example.com:3000can now be used for login and retained after restarting Gitify. Ports from 1 through 65535 are accepted; connections remain HTTPS, and authenticated follow-up requests must match both the hostname and port. Other forges retain their existing hostname validation.Verified with 1,654 passing tests, formatting, lint, TypeScript, and a production build. Chromium checks covered login success and failure, invalid ports, token-settings links, and account persistence after reload using mocked API responses and an Electron bridge stub. Five local review passes found no issues.
Closes #3323