feat(gitea): allow explicit HTTP instance origins - #3345
Merged
Merged
Conversation
github-actions
Bot
added
enhancement
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gitea and Forgejo instances without TLS can now be used with an explicit origin such as
http://git.internal:3000. Bare hostnames still default to HTTPS, and GitHub, GitLab and Bitbucket retain their existing hostname validation.Authenticated follow-up requests must match the configured scheme, host and port. Equivalent origin spellings replace an existing account's token while preserving its identifier and filters. This extends the optional-port validator already merged into main.
Verified with 1,727 passing unit/component tests and all 60 browser interaction and visual regression tests in CI, plus TypeScript, lint, formatting, and a local production build. The two updated Gitea screenshot baselines come from the pinned ARM64 Playwright CI environment. Visual diff uploads now include the hidden attachments directory. The built
file://renderer authenticated against a real local HTTP fixture, fetched notifications, and retained the account after reload with Chromium web security enabled. Packaged Electron was not exercised; its bridge was stubbed. Code review and the conflict-resolution follow-up have no outstanding findings.Related: #3344
Closes #3324