surface(macos): offset search overlay when occluding results#12960
Closed
alexbathome wants to merge 3 commits into
Closed
surface(macos): offset search overlay when occluding results#12960alexbathome wants to merge 3 commits into
alexbathome wants to merge 3 commits into
Conversation
Member
|
Hi Alex, I’m already working on this. The terminal part is under review. Claude did the most part. You are welcome to leave a review at #12942. |
Contributor
Author
Oh excellent work! Thanks @bo2themax ! I'll close this in favour of #12942 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR resolves issue #12512
When searching it is possible for the search result to be matched "under" the search bar itself. Leaving a confusing display to the user.
This PR, modifies the
search_selectedaction/SearchSelectedmessage such that we can pass back the search results viewport coordinates. This allows us to calculate an "avoidance" offset in the Swift UI code and "offset" the Search Bar's location on the display revealing the matched result underneath.A more pragmatic approach might be to detect the intersection between the search bar's rect and the result's rect and then using the Swift anchor/corners to move the bar around the display. I opted to use this offset approach because I find it a bit more aesthetic.
See example screen recording here:
Screen.Recording.2026-06-08.at.11.08.10.pm.mov
Notes
search_selectedkey what is the preferred approach here? (The mutation definitely breaks ABI regardless)