Skip to content

async-route: show load error in console #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alxndrsn merged 6 commits into from
Aug 6, 2026
Merged

async-route: show load error in console #1743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
31eff3d
async-route: show load error in console
Aug 5, 2026
03d6bb3
lint, whtespace
Aug 5, 2026
4dd9725
Update apps/central/src/components/async-route.vue
alxndrsn Aug 5, 2026
23a41a2
inject logger
Aug 5, 2026
2c5f227
Add exception for this message
Aug 5, 2026
6ebfab3
Merge branch 'master' into async-route-error
alxndrsn Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/central/src/components/async-route.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { noop } from '../util/util';
export default {
name: 'AsyncRoute',
components: { Loading, PageBody },
inject: ['alert', 'location'],
inject: ['alert', 'location', 'logger'],
inheritAttrs: false,
// See routes.js for more information about these props.
props: {
Expand Down Expand Up @@ -111,8 +111,10 @@ export default {
this.component = markRaw(m.default);
}
})
.catch(() => {
.catch(err => {
if (!canceled) {
this.logger.error('async-route', 'loadError:', err);

// It would be ideal to show a more informative error message.
// However, the error seems to provide limited information. For
// example, if there is a 404 because Frontend was rebuilt, the
Expand Down
3 changes: 3 additions & 0 deletions e2e-tests/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ const globalAllowedLogs = [
// * https://github.com/getodk/central/issues/1584
// * https://github.com/getodk/central/issues/2070
'SyntaxError: 17',

// Failing on these messages is highly disruptive, as it can randomly happen to non-fatal messages.
'Execution context was destroyed, most likely because of a navigation',
];

function isFatalConsoleMessage(allowedLogs, consoleMsg, normalisedMsg) {
Expand Down
Loading