async-route: show load error in console - #1743
Conversation
For the end-user, there is already a toast displayed when a load error occurs, reading: > The page you requested could not be loaded. Please refresh the page and try again. Without this logging, there is no indication to a developer what the error actually is.
|
|
Adding this logging sounds reasonable to me. 👍 We do similar logging when there's a normal request error (e.g., That said, I wouldn't expect to see these errors during local development. The main case I've seen it is when a server has been upgraded. |
Co-authored-by: Matthew White <matthew-white@users.noreply.github.com>
Can be triggered with a broken import: $ git diff
diff --git a/apps/central/src/components/user/edit/password.vue b/apps/central/src/components/user/edit/password.vue
index 7da343aa6..c95f52d7e 100644
--- a/apps/central/src/components/user/edit/password.vue
+++ b/apps/central/src/components/user/edit/password.vue
@@ -40,7 +40,7 @@ except according to the terms contained in the LICENSE file.
<script>
import FormGroup from '../../form-group.vue';
-import Spinner from '../../spinner.vue';
+import Spanner from '../../spinner.vue';
import useRequest from '../../../composables/request';
import { apiPaths } from '../../../util/request'; |
|
Ooh good point. OK maybe I'm totally misremembering and this error does come up. 🤔 |
|
Just wanted to make sure you saw the follow-up to my code suggestion. My first suggestion wasn't quite right. 😅 |
For the end-user, there is already a toast displayed when a load error occurs, reading:
Without this logging, there is no indication to a developer what the error actually is.
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
If bundle size or prod behaviour are sacrosanct, the logging could be filtered from the final bundle somehow?
How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
Most users won't encounter these errors, and if they do then they're unlikely to notice the logging.
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
No.