Skip to content

test(set): Pin intersect and column-pruning shapes to v2 #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbasmanova wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(set): Pin intersect and column-pruning shapes to v2 #1790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions axiom/optimizer/tests/SetTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,19 +309,18 @@ TEST_P(SetTest, intersect) {
.filter(filter);
};
auto matcher =
matchLeg("nationkey > 12")
matchLeg("nationkey > 11")
.hashJoin(
matchLeg("nationkey > 11")
matchLeg("nationkey > 12")
.hashJoin(
matchLeg("nationkey < 21 and (regionkey + 1) % 3 = 1"),
core::JoinType::kRightSemiFilter),
core::JoinType::kRightSemiFilter)
.singleAggregation()
.project()
.project()
.project({"n_regionkey + 1 as rk"})
.build();

AXIOM_ASSERT_PLAN_V1(plan, matcher);
AXIOM_ASSERT_PLAN_V2(plan, matcher);
}
}

Expand Down Expand Up @@ -674,9 +673,6 @@ TEST_P(SetTest, nondeterministicFilterAboveUnion) {
.filter("k::double > rand()")
.build());

// Asserted for v1 only: v2 gathers the union legs into one driver instead
// of spreading them round-robin, leaving the partial aggregation above it
// single-threaded.
AXIOM_ASSERT_DISTRIBUTED_PLAN_V1(
planVelox(logicalPlan).plan,
matchScan("nation")
Expand Down Expand Up @@ -783,18 +779,18 @@ TEST_P(SetTest, filterColumnPruningInUnionAll) {
// 'x' is filtered but not in the output, so it is pruned from each leg. The
// alias binds the (disambiguated on the second leg) filter column.
auto matchLeg = [](const std::string& filter) {
return matchScan("t").aliases({std::nullopt, "x"}).filter(filter).project();
return matchScan("t").aliases({"x", std::nullopt}).filter(filter).project();
};

{
auto matcher = matchLeg("x > 0").localPartition(matchLeg("x > 0")).build();
AXIOM_ASSERT_PLAN_V1(toSingleNodePlan(logicalPlan), matcher);
AXIOM_ASSERT_PLAN_V2(toSingleNodePlan(logicalPlan), matcher);
}

{
auto matcher =
matchLeg("x > 0").localPartition(matchLeg("x > 0")).gather().build();
AXIOM_ASSERT_DISTRIBUTED_PLAN_V1(planVelox(logicalPlan).plan, matcher);
AXIOM_ASSERT_DISTRIBUTED_PLAN_V2(planVelox(logicalPlan).plan, matcher);
}
}

Expand Down
Loading