test(set): Pin intersect and column-pruning shapes to v2 - #1790
Open
mbasmanova wants to merge 1 commit into
Open
test(set): Pin intersect and column-pruning shapes to v2#1790mbasmanova wants to merge 1 commit into
mbasmanova wants to merge 1 commit into
Conversation
Summary: Two `SetTest` assertions compared the plan only under v1, so v2's shape went unverified. Both now assert v2. In `intersect`, v2 probes the inner join with the more selective leg, making the intermediate that feeds the outer join's build side smaller, and it emits one trailing `Project` where v1 emits two. In `filterColumnPruningInUnionAll` the two optimizers differ only in the order of the scan's output columns, so the positional alias moves. Differential Revision: D117682348
meta-cla
Bot
added
the
CLA Signed
|
@mbasmanova has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117682348. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Two
SetTestassertions compared the plan only under v1, so v2's shape went unverified. Both now assert v2. Inintersect, v2 probes the inner join with the more selective leg, making the intermediate that feeds the outer join's build side smaller, and it emits one trailingProjectwhere v1 emits two. InfilterColumnPruningInUnionAllthe two optimizers differ only in the order of the scan's output columns, so the positional alias moves.Differential Revision: D117682348