Skip to content

fix result buffer overrun in decode-only benchmark #4714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saleemno1 wants to merge 1 commit into
base: dev
Choose a base branch
from
+6 −1
Open

fix result buffer overrun in decode-only benchmark #4714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion programs/benchzstd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ static BMK_benchOutcome_t BMK_benchMemAdvancedNoAlloc(
: chunkSize;
srcPtr += chunkSize;
cPtr += cCapacities[chunkID];
resPtr += chunkSize;
resPtr += resSizes[chunkID];
remaining -= chunkSize;
if (adv->mode == BMK_decodeOnly) {
cSizes[chunkID] = chunkSize;
Expand Down
5 changes: 5 additions & 0 deletions tests/playTests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,6 +1308,11 @@ zstd -f tmp1
zstd -b -d -i0 tmp1.zst
println "benchmark can fail - decompression on invalid data"
zstd -b -d -i0 tmp1 && die "invalid .zst data => benchmark should have failed"
println "benchmark decompression of several frames whose content is smaller than the frame"
printf 'a' > tmpbd1 ; printf 'b' > tmpbd2 ; printf 'c' > tmpbd3
zstd -qf tmpbd1 tmpbd2 tmpbd3
zstd -b -d -i0 tmpbd1.zst tmpbd2.zst tmpbd3.zst
rm -f tmpbd1 tmpbd2 tmpbd3 tmpbd1.zst tmpbd2.zst tmpbd3.zst

GZIPMODE=1
zstd --format=gzip -V || GZIPMODE=0
Expand Down