fix: Refine macOS WebView check so that it is false for browsers - #652
Merged
Conversation
rajivshah3
force-pushed
the
fix/only-macos-webview
branch
from
May 22, 2020 02:48
f397f3d to
e5e74d6
Compare
rajivshah3
marked this pull request as ready for review
May 22, 2020 02:53
|
Please let us know when do you plan to release it to npm? |
|
@eligrey @rajivshah3 is this going to be released? |
Contributor
Author
|
I'm not a maintainer so I'm not really sure |
|
@jimmywarting I saw you made a new release but not seeing it published - https://www.npmjs.com/package/file-saver. Is the latest version available in another package registry? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines check for macOS WebViews (originally implemented in #613) so that it is
falsefor Chrome, Safari, etc.User agent for WebView:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_5) AppleWebKit/605.1.15 (KHTML, like Gecko)Any browser running on macOS will have a similar user agent, but will also have one of these differences (source):
AppleWebKitin the stringSafariAdditionally, this is restricted to macOS (will be
falseon iOS) by testing forMacintoshThis fix is a bit more comprehensive, as #629 and #637 will still be
truefor SafariFixes #624