Revert "Use FileReader in macOS native apps using WebKit" - #651
Closed
rajivshah3 wants to merge 2 commits into
Closed
Revert "Use FileReader in macOS native apps using WebKit"#651rajivshah3 wants to merge 2 commits into
rajivshah3 wants to merge 2 commits into
Conversation
rajivshah3
marked this pull request as ready for review
May 22, 2020 01:32
Contributor
Author
|
@jimmywarting @eligrey sorry about that. Would you mind reviewing this when you get a chance? |
Owner
|
lgtm. I'm waiting on approval from @jimmywarting before I merge this. |
Contributor
Author
|
I think I'm able to fully fix this in #652 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #613, which broke file saving in Chrome. I'll try to figure out a different way to solve file saving for my use case
Fixes #624