Skip to content
This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
31963b9
ISAICP-6577: Topic select to use SlimSelect.
saidatom Oct 1, 2021
bafdd62
ISAICP-6577: Remove post-install-cmd slim_select library.
saidatom Oct 1, 2021
d5b71a2
Merge branch 'EPIC-6572' into ISAICP-6577
saidatom Oct 13, 2021
1f4790e
ISAICP-6577: Update slim_select module.
saidatom Oct 13, 2021
372fdc2
ISAICP-6577: Fix tests and enable multiple field.
saidatom Oct 17, 2021
4496aa5
ISAICP-6577: Fix xpath find topic.
saidatom Oct 17, 2021
69e0fff
ISAICP-6577: Replace test xpath Slim Select.
saidatom Oct 18, 2021
d8250a2
ISAICP-6577: Try to ensure that the loading state is complete.
idimopoulos Oct 19, 2021
b947fa7
Ensure that slow animations also finish.
idimopoulos Oct 19, 2021
75647eb
ISAICP-6577: Modernize the way to wait for an element to be found.
idimopoulos Oct 20, 2021
c86dfce
ISAICP-6577: The find method might return NULL.
idimopoulos Oct 20, 2021
ecc9c87
Merge remote-tracking branch 'origin/EPIC-6572' into ISAICP-6577
saidatom Oct 21, 2021
fef702b
Merge remote-tracking branch 'origin/EPIC-6572' into ISAICP-6577
saidatom Oct 21, 2021
de65be7
ISAICP-6577: Fix remarks to improve tests.
saidatom Oct 21, 2021
7ed4b2c
ISAICP-6577: Fix homepage feature Slim Select test.
saidatom Oct 21, 2021
a9a1a8e
Merge remote-tracking branch 'origin/EPIC-6572' into ISAICP-6577
claudiu-cristea Oct 25, 2021
3313a22
ISAICP-6577: Add waitfor element to prevent error.
saidatom Oct 25, 2021
5850f34
ISAICP-6577: Add abstraction find Slim Select.
saidatom Oct 26, 2021
e7a263b
Merge remote-tracking branch 'origin/EPIC-6572' into ISAICP-6577
saidatom Oct 26, 2021
48657ac
ISAICP-6577: Fix abstraction.
saidatom Oct 27, 2021
b4e52ee
ISAICP-6577: Add waitfor element to prevent error.
saidatom Oct 27, 2021
66ba282
ISAICP-6577: Add waitfor element to prevent error.
saidatom Oct 27, 2021
1cc406e
ISAICP-6577: Remove findSlimSelect in options.
saidatom Oct 28, 2021
6c06981
ISAICP-6577: Add waitfor element to prevent error.
saidatom Oct 28, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
"drupal/simplenews": "^1.0-beta1",
"drupal/site_alert": "~1.2",
"drupal/site_verify": "1.x-dev",
"drupal/slim_select": "^1.0@alpha",
"drupal/smart_trim": "~1.3",
"drupal/social_media_links": "^2.7",
"drupal/spdx": "^1.0",
Expand Down
71 changes: 68 additions & 3 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions config/sync/core.extension.yml
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ module:
simple_sitemap: 0
site_alert: 0
site_verify: 0
slim_select: 0
smart_trim: 0
social_media_links: 0
social_media_links_field: 0
Expand Down
14 changes: 1 addition & 13 deletions config/sync/facets.facet.topic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ name: Topics
url_alias: topic
weight: -3
min_count: 1
show_only_one_result: true
show_only_one_result: false
field_identifier: topic
facet_source_id: 'search_api:views_page__search__page_1'
widget:
Expand All @@ -30,12 +30,6 @@ hard_limit: 0
exclude: false
only_visible_when_facet_source_is_visible: true
processor_configs:
active_widget_order:
processor_id: active_widget_order
weights:
sort: -8
settings:
sort: ASC
aggregated_entity_reference_label:
processor_id: aggregated_entity_reference_label
weights:
Expand All @@ -48,12 +42,6 @@ processor_configs:
settings:
minimum_items: 1
maximum_items: null
count_widget_order:
processor_id: count_widget_order
weights:
sort: -10
settings:
sort: ASC
display_value_widget_order:
processor_id: display_value_widget_order
weights:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
uuid: 9dac5cf8-020e-4f0a-8c0c-e8359168af17
langcode: en
status: true
dependencies: { }
id: search_api__views_page__search__page_1
name: 'search_api:views_page__search__page_1'
filter_key: null
url_processor: query_string
breadcrumb: { }
6 changes: 3 additions & 3 deletions tests/features/homepage.feature
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Feature: Homepage
# page instead.
When I click "Finance in EU"
Then I should be on the advanced search page
And the option with text "Finance in EU" from select facet form "topic" is selected
And the option with text "- Finance in EU" from select "Topics" is selected

# There is a "More news" link that for the moment leads to the search page
# pre-filtered on news articles. In the future this will become a dedicated
Expand Down Expand Up @@ -203,7 +203,7 @@ Feature: Homepage
And I should see the link "E-justice" in the "Discover topics block"
When I click "E-justice"
Then I should be on the advanced search page
And the option with text "E-justice" from select facet form "topic" is selected
And the "E-justice" option from "topic" Slim Select is selected

# See more topics modal.
When I am on the homepage
Expand Down Expand Up @@ -231,7 +231,7 @@ Feature: Homepage
| Social and Political |
When I click "E-health Dpt." in the "Modal content"
Then I should be on the advanced search page
And the option with text "E-health Dpt." from select facet form "topic" is selected
And the "E-health Dpt." option from "topic" Slim Select is selected
And the page should show the tiles "Internet medicine"

Examples:
Expand Down
4 changes: 2 additions & 2 deletions tests/features/joinup_search/group_search.feature
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ Feature: Search inside groups
Then the page should not contain any chips

When I select "Inclined foundations" from the "collection/solution" select facet form
And I click Search in facets form
And I press "Search"
Then the option with text "Inclined foundations (6)" from select facet form "collection/solution" is selected
And I should see 6 tiles

Expand All @@ -244,7 +244,7 @@ Feature: Search inside groups
# The filter facets summary shouldn't remain active when doing another search.
When I enter "ground" in the search bar and press enter
Then I select "Inclined foundations" from the "collection/solution" select facet form
And I click Search in facets form
And I press "Search"
And I should see 2 tiles
When I open the search bar by clicking on the search icon
And I should see the following facet summary "Inclined foundations"
Loading