ISAICP-6577: Topic select to use SlimSelect. by saidatom · Pull Request #2592 · ec-europa/joinup-dev

saidatom · 2021-09-22T16:42:59Z

No description provided.

claudiu-cristea

Before doing a detailed QA, we need to fix:

Looking to mockups, at https://citnet.tech.ec.europa.eu/CITnet/jira/browse/ISAICP-6572 (multiselect - Desktop.pdf), I see there is a multiselect Slim Select. But here we have a single select. Should be fixed.
Tests are failing. I tried locally and failed for me too, but in a different line. We should find out why and fix. The fact that it passes locally and failing in CPHP cannot be explained generically with "infrastructure issue". It's new test coverage and should pass.

claudiu-cristea

Apart from the inline remarks, we need to test multi-select.

claudiu-cristea · 2021-10-26T08:36:17Z

+   *
+   * @When I select :option option(s) from the :label Slim Select
+   */
+  public function iSelectAnOptionFromSlimSelect(string $option, string $label): void {


a/iSelectAnOptionFromSlimSelect/iSelectOptionsFromSlimSelect

claudiu-cristea · 2021-10-26T08:44:04Z

+    $facet_id = self::getFacetIdFromAlias($label);
+    $session = $this->getSession();
+    $xpath = '//div[contains(concat(" ", normalize-space(@class), " "), " block-facets-form ")]//select[@data-drupal-selector="' . $facet_id . '"]';
+    $slim_select = $session->getPage()->find('xpath', $xpath);
+    if (!$slim_select) {
+      throw new \Exception("The Slim Select '$label' was not found in the page.");
+    }


The idea of abstracting the Slim Select search/find into a protected method was not implemented. Also we have here hadcoded references to Facets Form. We need a generic step definition that work not only for Facets Form but for any Slim Select on the site. Should be only searchable by its label: get the native select > (wait to be rendered) > get the Slim Select.

claudiu-cristea · 2021-10-26T08:44:28Z

+    $facet_id = self::getFacetIdFromAlias($select);
+    $region = $this->getSession()->getPage();
+    $slim_select = $region->find('xpath', "//*[@data-drupal-selector='{$facet_id}']");
+
+    if (!$slim_select) {
+      throw new \Exception(sprintf('The select "%s" was not found in the page %s', $select, $this->getSession()->getCurrentUrl()));
+    }
+


Same. Need abstraction.

claudiu-cristea · 2021-10-26T08:44:57Z

+    $facet_id = self::getFacetIdFromAlias($select);
+    $region = $this->getSession()->getPage();
+    $xpath = "//*[@data-drupal-selector='{$facet_id}']";
+    $page = $this->getSession()->getPage();


Same. Abstraction

claudiu-cristea · 2021-10-26T08:46:09Z

   */
-  public function iClickActionsInFacetsForm(string $name) {
+  public function iClickSearchInFacetsForm(string $name) {
    $region = $this->getSession()->getPage();
-    $element = $region->find('xpath', "//input[@value='{$name}']");
-    $element->click();
+    $xpath = '//div[contains(concat(" ", normalize-space(@class), " "), " block-facets-form ")]//div[@data-drupal-selector="edit-actions"]';
+    $actions = $region->find('xpath', $xpath);
+
+    $element = $actions->find('css', "input[value|='{$name}']");
+    $element->submit();
  }


We don't need this. Use When I press "Search".

claudiu-cristea · 2021-10-26T08:59:14Z

+    $slim_select = $region->find('xpath', "//*[@data-drupal-selector='{$facet_id}']");
+
+    if (!$slim_select) {
+      throw new \Exception(sprintf('The select "%s" was not found in the page %s', $select, $this->getSession()->getCurrentUrl()));


Use ElementNotFoundException everywhere it applies.

claudiu-cristea · 2021-10-26T09:00:36Z

+      $xpath = '//div[contains(concat(" ", normalize-space(@class), " "), " block-facets-form ")]//div[contains(concat(" ", normalize-space(@class), " "), "' . $slim_select->getAttribute('data-ssid') . '")]';
+      $select = $session->getPage()->waitFor(5, function () use ($session, $xpath) {
+        return $session->getPage()->find('xpath', $xpath);
+      });


Move this into the new findSlimSelect() methods so it applies everywhere we need to get the Slim Select.

claudiu-cristea · 2021-10-26T09:11:03Z

+      throw new \Exception(sprintf('The select "%s" was not found in the page %s', $select, $this->getSession()->getCurrentUrl()));
+    }
+
+    if ($this->browserSupportsJavaScript()) {


All Slim Select step definitions should only work with Selenium tests. Use \Drupal\joinup\Traits\MaterialDesignTrait::selectMaterialDesignRadioButton() as an example on how to enforce this.

For the test that runs w/o JS (tests/features/homepage.feature) use the @Then the option with text :option from select :select is selected step def.

Base automatically changed from ISAICP-6584 to ISAICP-6415 September 24, 2021 05:45

saidatom changed the base branch from ISAICP-6415 to EPIC-6572 September 28, 2021 13:56

saidatom changed the base branch from EPIC-6572 to ISAICP-6415 September 28, 2021 14:00

pfrenssen force-pushed the ISAICP-6415 branch from 0ccd98b to 1459abc Compare September 28, 2021 14:50

saidatom changed the base branch from ISAICP-6415 to EPIC-6572 September 30, 2021 12:16

saidatom changed the base branch from EPIC-6572 to ISAICP-6415-backup October 1, 2021 12:32

ISAICP-6577: Topic select to use SlimSelect.

31963b9

saidatom force-pushed the ISAICP-6577 branch from 5162785 to 31963b9 Compare October 1, 2021 12:46

saidatom changed the base branch from ISAICP-6415-backup to EPIC-6572 October 1, 2021 12:46

saidatom changed the base branch from EPIC-6572 to ISAICP-6688 October 1, 2021 12:51

ISAICP-6577: Remove post-install-cmd slim_select library.

bafdd62

Base automatically changed from ISAICP-6688 to EPIC-6572 October 13, 2021 16:16

saidatom added 2 commits October 13, 2021 17:48

Merge branch 'EPIC-6572' into ISAICP-6577

d5b71a2

ISAICP-6577: Update slim_select module.

1f4790e

claudiu-cristea suggested changes Oct 14, 2021

View reviewed changes

Comment thread web/modules/custom/joinup_search/joinup_search.module Outdated

saidatom and others added 5 commits October 17, 2021 16:15

ISAICP-6577: Fix tests and enable multiple field.

372fdc2

ISAICP-6577: Fix xpath find topic.

4496aa5

ISAICP-6577: Replace test xpath Slim Select.

69e0fff

ISAICP-6577: Try to ensure that the loading state is complete.

d8250a2

Ensure that slow animations also finish.

b947fa7

idimopoulos force-pushed the ISAICP-6577 branch from 0ab9f82 to 9d9f31e Compare October 20, 2021 10:05

ISAICP-6577: Modernize the way to wait for an element to be found.

75647eb

idimopoulos force-pushed the ISAICP-6577 branch from 9d9f31e to 75647eb Compare October 20, 2021 10:15

ISAICP-6577: The find method might return NULL.

c86dfce

claudiu-cristea suggested changes Oct 21, 2021

View reviewed changes

saidatom added 4 commits October 21, 2021 08:57

Merge remote-tracking branch 'origin/EPIC-6572' into ISAICP-6577

ecc9c87

Merge remote-tracking branch 'origin/EPIC-6572' into ISAICP-6577

fef702b

ISAICP-6577: Fix remarks to improve tests.

de65be7

ISAICP-6577: Fix homepage feature Slim Select test.

7ed4b2c

saidatom force-pushed the ISAICP-6577 branch from d2c66d5 to 7ed4b2c Compare October 21, 2021 14:49

claudiu-cristea and others added 2 commits October 25, 2021 19:42

Merge remote-tracking branch 'origin/EPIC-6572' into ISAICP-6577

a9a1a8e

ISAICP-6577: Add waitfor element to prevent error.

3313a22

claudiu-cristea reviewed Oct 26, 2021

View reviewed changes

saidatom added 3 commits October 26, 2021 21:10

ISAICP-6577: Add abstraction find Slim Select.

5850f34

Merge remote-tracking branch 'origin/EPIC-6572' into ISAICP-6577

e7a263b

ISAICP-6577: Fix abstraction.

48657ac

saidatom force-pushed the ISAICP-6577 branch from 8dd9016 to 48657ac Compare October 27, 2021 15:16

saidatom added 3 commits October 27, 2021 18:11

ISAICP-6577: Add waitfor element to prevent error.

b4e52ee

ISAICP-6577: Add waitfor element to prevent error.

66ba282

ISAICP-6577: Remove findSlimSelect in options.

1cc406e

saidatom force-pushed the ISAICP-6577 branch from 7e0d3ae to 1cc406e Compare October 28, 2021 12:34

ISAICP-6577: Add waitfor element to prevent error.

6c06981

Uh oh!

Conversation

saidatom commented Sep 22, 2021

Uh oh!

claudiu-cristea left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

claudiu-cristea left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants