Skip to content

fix: Filter out "load" errors from thumbnail error reporting #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinPayravi merged 3 commits into from
May 9, 2026
Merged

fix: Filter out "load" errors from thumbnail error reporting #1517

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6e4df7
Only log status codes >= 400
KevinPayravi May 9, 2026
2450b59
Skip logging nonactionable load errors
KevinPayravi May 9, 2026
95e28c3
Merge branch 'main' into thumb-error-improvements
KevinPayravi May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/probeImage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ async function detectErrorType(url, fallbackType) {
if (Number.isInteger(response?.status) && response.status >= 400) {
return String(response.status);
}

// If an <img> onerror fires but HEAD returns non-error status,
// treat it as a non-actionable mismatch and skip.
if (fallbackType === "load") {
return null;
}
} catch {
// Ignore; fallbackType is returned below.
} finally {
Expand Down Expand Up @@ -121,6 +127,7 @@ const probeImage = (url, onError, provider, sourceUrl) => {
if (!cancelled) {
const pageUrl = typeof window !== "undefined" ? window.location?.href || "" : "";
void detectErrorType(url, "load").then((errorType) => {
if (!errorType) return;
reportThumbnailError(url, provider, sourceUrl, pageUrl, errorType);
});
onError();
Expand Down
Loading