Skip to content

fix: Filter out "load" errors from thumbnail error reporting - #1517

Merged
KevinPayravi merged 3 commits into
mainfrom
thumb-error-improvements
May 9, 2026
Merged

fix: Filter out "load" errors from thumbnail error reporting#1517
KevinPayravi merged 3 commits into
mainfrom
thumb-error-improvements

Conversation

@KevinPayravi

@KevinPayravi KevinPayravi commented May 9, 2026

Copy link
Copy Markdown
Member

Our new thumbnail error reporting is filled with load errors. When looking into them, I found that the thumbnails loaded fine in my browser. But digging it into more, I believe the root cause is that our thumbnails don't have a Content-Type header. This may cause thumbnails to silently fail in the background, or potentially in cases of scrapers/crawlers trying to "view" them.

I've created two PRs on the thumbnail-api and thumbnailer-lambda repos to fix this, by attaching a correct Content-Type to our thumbnails:
dpla/thumbnail-api#31
dpla/thumbnailer-lambda#12

In the meantime, this PR removes "load" errors from our logging to cut back on the noise. We may restore it if we want once the Content-Type fixes are deployed.

@coderabbitai

coderabbitai Bot commented May 9, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@KevinPayravi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 9 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9f83e83b-748c-4013-a038-094c5e87d3cb

📥 Commits

Reviewing files that changed from the base of the PR and between 676eead and 95e28c3.

📒 Files selected for processing (1)
  • lib/probeImage.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch thumb-error-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KevinPayravi
KevinPayravi merged commit d597be6 into main May 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant