Add VBD and AVBD paper-parity foundation - #3432
Conversation
…r-parity-contract
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 995be410b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58bf1c3e85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57bce9a5ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
DART 7, including public solver selection, rigid pair constraints, and
independently attributable Sequential Impulse, fixed-penalty VBD, and AVBD
Figure 13 rows.
partial or missing; this PR does not claim paper parity, GPU parity, or a
paper/reference speedup.
Motivation / Problem
can be completed in two ordered PRs: VBD first, then AVBD. Existing partial
implementations and evidence did not fail closed on solver identity,
source/build provenance, visual outcomes, CPU/CUDA coverage, or comparable
achieved-accuracy performance.
Changes / Key Changes
VBD/AVBD completion predicates.
dual/stiffness updates, articulated finite rows and motors, physical fracture
accounting, and public C++/dartpy rigid-solver configuration.
Sequential Impulse family own hard rigid pair rows, bounded velocity motors,
fracture, and post-stabilization rather than borrowing AVBD projection.
validation, and descriptive same-host benchmark evidence for SI, VBD, and
AVBD.
and the required foundation -> VBD PR -> AVBD PR execution sequence.
Before / After
Testing
Current head
57bce9a5cedf:DART_DISABLE_COMPILER_CACHE=ON pixi run test-all(all 6 phases passed;lint, release/debug builds, 229/229 core C++ tests, 81 runnable simulation
tests, the full Python corpus, and documentation)
PYTHONUNBUFFERED=1 DART_DISABLE_COMPILER_CACHE=ON pixi run -e cuda test-all(all 7 phases passed; 213/213 core C++ tests, 80 runnable simulation tests,
the full Python corpus, 8/8 CUDA device tests, and all 9 benchmark-smoke
commands)
build/default/cpp/Release/bin/test_world --gtest_filter=World.PublicVbdFamilyRequiresFinitePointJointProjectionStiffness(1/1 public fixed/revolute/prismatic/spherical hard-row regression passed)
pixi run check-avbd-packets(58 packets)pixi run check-plan104-paper-parity(176 canonical rows)7a96ffd3b73b9649961ed858f7d9967044b6e2fe47477227e04e2840c5f0b4d0Visual verification
separate semantic reviews for SI, fixed-penalty VBD, and AVBD. They pass
engine ViewReports, pixel-integrity checks, image verdicts, and
original-resolution review against the pinned paper page.
replication. No video bundle was generated for this foundation slice, and
transient media is intentionally not committed.
without another code PR. Full paper/site/official-video/source-demo image,
GIF, and video evidence will ship inside exactly two follow-ups: the VBD
completion PR first, then the AVBD completion PR. There will be no separate
media-only PR.
media stays ignored locally and reviewer-facing media uses GitHub
attachments. It does not copy Add opt-in exact-Coulomb FBF friction solver and fix split-impulse impulse loss #3377's still-incomplete claim boundary.
Breaking Changes
behavior now attributes hard pair constraints to Sequential Impulse and
routes finite-stiffness pair constraints to VBD/AVBD.
Related Issues / PRs (backports)
Checklist
docs/onboarding/changelog.md