Repository navigation
Conversation
The refactor in damontecres#1955 swapped the preferAc3ForSurround branches, so video transcodes were restricted to AC3 by default. Devices without an AC3 decoder or passthrough played video with no audio.
Owner
|
Hey @StefanBS, why did you close this? I think you're right that this is a bug. |
This was referenced Oct 19, 2026
damontecres
added a commit
that referenced
this pull request
Oct 19, 2026
## Description The refactor in #1955 (included in `v1.0.9`) swapped the branches for the experimental "Use AC3 for surround sound audio" breaking it. Unfortunately, there isn't a real workaround to get the AC3 behavior back. With the experimental settings enabled & "Use AC3 for surround sound audio" _disabled_, surround sound audio will transcode to stereo AAC. Otherwise if experimental settings are _disabled_ and/or "Use AC3 for surround sound audio" is _enabled_, there's no effect. ### Related issues Credit to @StefanBS who opened #2090, but closed it before I verified the bug Closes #2093 ### Testing Manually via emulator ## Screenshots N/A ## AI or LLM usage None
Contributor
Author
Claude accidentally opened this PR while troubleshooting an issue I was having which turned out to be unrelated to this, and I forgot to follow through with this. Thanks for mentioning me in your fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1955 swapped the
preferAc3ForSurroundbranches in the video transcoding profile, so by default every video transcode was AC3-only. Devices that can't decode or pass through AC3 play video with no audio. Music isn't affected because its transcoding profile was refactored correctly.Evidence
TestDeviceProfileUtils: 8 tests, 2 failedvideo transcoding allows all audio codecs when not preferring AC3: expected[aac, ac3, eac3, …]but was[ac3]video transcoding uses only AC3 when preferring AC3: expected[ac3]but was[aac, ac3, eac3, …]Merge Danger
Door: two-way
Restores the v1.0.8 behavior.
Blast Radius: transcoding
Changes only the audio codecs the server may pick when it transcodes or remuxes video.