Repository navigation
Fix experimental settings for AC3 surround sound - #2101
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The refactor in #1955 (included in
v1.0.9) swapped the branches for the experimental "Use AC3 for surround sound audio" breaking it.Unfortunately, there isn't a real workaround to get the AC3 behavior back. With the experimental settings enabled & "Use AC3 for surround sound audio" disabled, surround sound audio will transcode to stereo AAC. Otherwise if experimental settings are disabled and/or "Use AC3 for surround sound audio" is enabled, there's no effect.
Related issues
Credit to @StefanBS who opened #2090, but closed it before I verified the bug
Closes #2093
Testing
Manually via emulator
Screenshots
N/A
AI or LLM usage
None