Repository navigation
Guard against crash if episode has seasonId but no seriesId - #1964
Merged
Merged
Conversation
seasonId but no seriesIdseasonId but no seriesId
Owner
Author
|
A few hours later and the episode was fixed, so this was probably just an edge case during a library scan. But guarding against a potential crash is still a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When clicking on an episode, the app assumes if there is a season ID for the episode, then there must be a series ID. However, on my JF 12.0 server, an episode (with no metadata) appeared on my Continue Watching and it has a season ID (which in turn has a series ID) but no series ID.
I'm not sure if this really a valid situation or if it's a server bug, but Wholphin shouldn't crash at least. So this PR checks both
seasonIdandseriesIdand if either is null, falls back to the generic "Episode Page". Similarly, if a season has noseriesId(again, not sure if a valid situation), a crash won't occur, however there is no generic "Season Page", so an error page is shown.Related issues
TODO, check JF server issues, maybe fixed in 12.1?
Testing
Emulator
Screenshots
N/a
AI or LLM usage
None