Repository navigation
Quick Connect QR code for "Sign in with theweasel.tv" and the Jellyfin 12 fixes - #20
Merged
Merged
Conversation
…ntecres#1964) ## Description When clicking on an episode, the app assumes if there is a season ID for the episode, then there must be a series ID. However, on my JF 12.0 server, an episode (with no metadata) appeared on my Continue Watching and it has a season ID (which in turn has a series ID) but no series ID. I'm not sure if this really a valid situation or if it's a server bug, but Wholphin shouldn't crash at least. So this PR checks both `seasonId` and `seriesId` and if either is null, falls back to the generic "Episode Page". Similarly, if a season has no `seriesId` (again, not sure if a valid situation), a crash won't occur, however there is no generic "Season Page", so an error page is shown. ### Related issues TODO, check JF server issues, maybe fixed in 12.1? ### Testing Emulator ## Screenshots N/a ## AI or LLM usage None
WeaselFin builds now carry QUICK_CONNECT_APPROVE_URL (the website's approve page) and QUICK_CONNECT_APPROVE_LABEL (theweasel.tv/plex). When a Quick Connect code arrives, the dialog shows a QR code for <approve url>?code=<code>&device=tv above the six digits, with the hint "Scan with your phone, or go to theweasel.tv/plex and enter the code". The phone opens the page, signs in with the website account and approves the code; the TV keeps polling as before, now every two seconds instead of five so the sign-in lands promptly. Upstream flavors leave both fields blank and keep the plain code dialog. zxing-core (pure Java) renders the QR bitmap, black on white. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3.3 (and Phase 1 step 5) of the one sign-in plan (Notion: Implementation plan — one sign-in for theweasel.tv and WeaselPlex). Pairs with platform PR damontecres#134 (
/weaselplex/connectapprove page, merged).What changed
SwitchUserContent.kt, newQuickConnectQrCode.kt): when WeaselPlex hands back a code, the dialog shows a QR forhttps://theweasel.tv/weaselplex/connect?code=<code>&device=tvabove the six digits, with the hint "Scan with your phone, or go to theweasel.tv/plex and enter the code". The phone signs in with the website account and approves the code; the TV keeps polling and signs in as before.SwitchUserViewModel.kt) so an approved code lands promptly.QUICK_CONNECT_APPROVE_URL/QUICK_CONNECT_APPROVE_LABELbuild fields are blank indefaultConfigand set only in theweaselfinflavor, so upstream flavors keep the plain code dialog and rebases stay clean.com.google.zxing:core3.5.3 added (pure Java QR encoder, no camera dependency).seasonIdbut noseriesIddamontecres/Wholphin#1964)" and "Catch & display error during loading a series".Checks
./gradlew :app:compileWeaselfinDebugKotlinpasses.v1.2.5tag and the theweasel.tv publish are owner-gated; the website side needsWEASELPLEX_PORTAL_ENABLED=truein production for the approve page to be live.Owner review points
🤖 Generated with Claude Code