-
Notifications
You must be signed in to change notification settings - Fork 3.6k
chore: wire CDP Fetch runtime when proxy is disabled #34276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cacieprins
wants to merge
8
commits into
develop
Choose a base branch
from
cacie/34271/cdp-runtime-when-proxy-disabled
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0b79933
chore: wire CDP Fetch runtime when proxy is disabled
cacieprins 0b95a9d
fix: restore lightweight CDP Fetch runtime for proxy-disabled mode
cacieprins ec35f65
Disable proxy detection when proxy is disabled
cacieprins b92e23c
fix: keep CDP Fetch alive across tests and preserve AUT frame header
cacieprins 08027c5
fix: align internal route config types with optional RuntimeConfigOpt…
cacieprins ad0e214
fix: stub rendered-HTML-origins for websockets when the proxy is disa…
AtofStryker a8936cb
fix: carry the browser's absolute URL in the internal-route loopback …
AtofStryker a880bfb
fix: harden CDP Fetch runtime teardown and scope the AUT-frame header…
AtofStryker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| // Marks a document request as originating from the AUT frame so downstream | ||
| // consumers (e.g. proxy request-middleware) can identify it for injection. | ||
| // Every automation layer (CDP, BiDi, WebKit) injects this header; the proxy | ||
| // strips it before the request goes upstream. | ||
| export const AUT_FRAME_HEADER = 'X-Cypress-Is-AUT-Frame' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AUT header leaks upstream without proxy
Medium Severity
With the MITM proxy disabled, CDP Fetch adds
X-Cypress-Is-AUT-Frameon AUT documentFetch.continueRequestcalls. That traffic no longer passes throughNetworkProxyrequest middleware, which previously removed the header before upstream requests. External AUT navigations can therefore send this internal Cypress marker to the application origin.Reviewed by Cursor Bugbot for commit a880bfb. Configure here.