chore: wire CDP Fetch runtime when proxy is disabled#34276
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Merging develop reintroduced CreateProxyRuntimeDeps on createCdpFetchRuntime, which broke the proxy-disabled call site that only passes client/isAUTFrame. Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Reset clears in-flight state without disabling Fetch, and continueRequest headers always include X-Cypress-Is-AUT-Frame when the request is AUT-frame. Co-authored-by: Cursor <cursoragent@cursor.com>
cypress
 |
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
cacie/34271/cdp-runtime-when-proxy-disabled
|
| Run status |
|
| Run duration | 09m 27s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
2
|
 |
0
|
 |
32
|
| View all changes introduced in this branch ↗︎ | |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
Keep the lightweight CDP Fetch runtime while adopting internal route serving and loopback header handling from develop. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f82a6c7. Configure here.
| // browser was launched outside Cypress. | ||
| if (isProxyDisabled()) { | ||
| return next() | ||
| } |
There was a problem hiding this comment.
Proxy off skips cy-in-cy fix
Low Severity
When CYPRESS_INTERNAL_DISABLE_PROXY is set, _forceProxyMiddleware returns next() before any later logic. The CYPRESS_INTERNAL_E2E_TESTING_SELF branch that rewrites path-only proxiedUrl values from the referer never runs, so cy-in-cy self tests with the proxy disabled can keep incorrect URLs.
Reviewed by Cursor Bugbot for commit f82a6c7. Configure here.
…ions Cfg.clientRoute is optional because RuntimeConfigOptions extends Partial<RuntimeServerConfigOptions>. Reuse InternalRouteConfig for CDP Fetch runtime deps so server-base can pass _openConfig without TS2322. Co-authored-by: Cursor <cursoragent@cursor.com>
1 participant
Additional details
Wires the CDP Fetch network runtime when the MITM proxy is disabled (
CYPRESS_INTERNAL_DISABLE_PROXY), so AUT request/response traffic is surfaced through CDP Fetch instead of the Node proxy.ServerBase.createCdpFetchNetworkRuntimeand hooks it from Chrome/Electron viaonPageCriClientReadywhen the proxy is disabledcreateCdpFetchRuntimeto a lightweight HttpIntercept + CdpFetchTransport path (no legacy NetworkProxy pipeline)isAUTFrameinto the CDP Fetch transport for AUT-frame correlationDepends on the CDP Fetch transport from #34222.
Steps to test
CYPRESS_INTERNAL_DISABLE_PROXY=1) against a Chromium browser.How has the user experience changed?
No change for default (proxy-enabled) runs. Enables the proxy-disabled CDP Fetch path for the HTTP/2 interception migration.
PR Tasks
cypress-documentation?type definitions?Made with Cursor