-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Add sans-fitter to conda-forge #34564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a211f7c
Add sans-fitter to conda-forge
MridulS e0a2aa7
Add columnize in deps
MridulS 5d7d8ab
Update recipe.yaml
MridulS 7319262
Update recipe.yaml
MridulS 12177dd
Update recipes/sans-fitter/recipe.yaml
MridulS bde473a
Update recipe.yaml
MridulS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| schema_version: 1 | ||
|
|
||
| context: | ||
| version: "0.2.2" | ||
| python_min: "3.12" | ||
|
|
||
| package: | ||
| name: sans-fitter | ||
| version: ${{ version }} | ||
|
|
||
| source: | ||
| url: https://pypi.org/packages/source/s/sans-fitter/sans_fitter-${{ version }}.tar.gz | ||
| sha256: 9646566d1ce8dd03d1437a87a24c8b12d084135a6c225fd7fc96d61c33171da3 | ||
|
|
||
| build: | ||
| number: 0 | ||
| noarch: python | ||
| script: ${{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation | ||
|
|
||
| requirements: | ||
| host: | ||
| - python ${{ python_min }}.* | ||
| - setuptools >=61.0 | ||
| - wheel | ||
| - pip | ||
| run: | ||
| - python >=${{ python_min }} | ||
| - numpy >=1.20 | ||
| - plotly >=5.0 | ||
| - scipy >=1.7 | ||
| - sasmodels >=1.0 | ||
| - sasdata >=0.8 | ||
| - bumps >=0.9 | ||
| - jupyter >=1.0 | ||
| - notebook >=7.0 | ||
| - ipykernel >=6.0 | ||
| - ipywidgets >=8.0 | ||
| - columnize | ||
|
|
||
| tests: | ||
| - python: | ||
| imports: | ||
| - sans_fitter | ||
| pip_check: false # sasmodels 1.1.0 has unresolved tccbox metadata | ||
| python_version: | ||
| - ${{ python_min }}.* | ||
| - "*" | ||
|
|
||
| about: | ||
| summary: A flexible template for fitting SANS data with SasModels | ||
| license: BSD-3-Clause | ||
| license_file: LICENSE | ||
| homepage: https://pypi.org/project/sans-fitter/ | ||
|
MridulS marked this conversation as resolved.
Outdated
|
||
|
|
||
| extra: | ||
| recipe-maintainers: | ||
| - MridulS | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix this in statsmodel first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @ocefpaf! I'm trying to get this fixed upstream first SasView/sasmodels#752 but it will probably take some time going through the stack and a release. Is it possible to get it on conda-forge and then I can update the feedstock with the pip check with the new release?
PS: no 't', sasmodels :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See conda-forge/sasmodels-feedstock#20 for the fix. Can you mark the build number 0 as broken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda-forge/admin-requests#2284
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this recipe to do a pip check and it's happy, thanks!