Skip to content

Add sans-fitter to conda-forge - #34564

Merged
ocefpaf merged 6 commits into
conda-forge:mainfrom
MridulS:sans-fitter
Aug 19, 2026
Merged

Add sans-fitter to conda-forge#34564
ocefpaf merged 6 commits into
conda-forge:mainfrom
MridulS:sans-fitter

Conversation

@MridulS

@MridulS MridulS commented Aug 18, 2026

Copy link
Copy Markdown
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated recipe".
  • Recipe uses the v1 recipe.yaml format, or this PR explains the exceptional requirement for deprecated v0.
  • License file is packaged (see the v1 example recipe for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sans-fitter/recipe.yaml) and found it was in an excellent condition.

@MridulS
MridulS marked this pull request as draft August 18, 2026 22:25
@MridulS
MridulS marked this pull request as ready for review August 19, 2026 07:04
@MridulS

MridulS commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

@conda-forge/help-python ready for review!

Comment thread recipes/sans-fitter/recipe.yaml Outdated
Co-authored-by: UENO, M. <eunosium-1128@live.jp>
Comment thread recipes/sans-fitter/recipe.yaml Outdated
- python:
imports:
- sans_fitter
pip_check: false # sasmodels 1.1.0 has unresolved tccbox metadata

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix this in statsmodel first.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @ocefpaf! I'm trying to get this fixed upstream first SasView/sasmodels#752 but it will probably take some time going through the stack and a release. Is it possible to get it on conda-forge and then I can update the feedstock with the pip check with the new release?

PS: no 't', sasmodels :D

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See conda-forge/sasmodels-feedstock#20 for the fix. Can you mark the build number 0 as broken?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this recipe to do a pip check and it's happy, thanks!

@ocefpaf
ocefpaf merged commit e15a22c into conda-forge:main Aug 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants