[consensus/marshal] Acquire blocks by exact commitment - #4878
Draft
patrick-ogrady wants to merge 1 commit into
Draft
patrick-ogrady wants to merge 1 commit into
patrick-ogrady wants to merge 1 commit into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | f8e653c | Sep 21 2026, 06:02 AM |
This was referenced Sep 21, 2026
patrick-ogrady
added this pull request to stack #4881
September 21, 2026 05:44
Benchmark resultsRegressions: ✅ `qmdb::merkleize/v=any::unordered::fixed::mmr k=10000 ch=false s=true cc=true` (2/2 gates passed)
✅ `qmdb::merkleize/v=current::ordered::fixed::mmb chunk=256 k=10000 ch=false s=true cc=true` (2/2 gates passed)
Baseline commit(s): |
patrick-ogrady
force-pushed
the
revamped-marshal-exact-acquisition
branch
from
September 21, 2026 06:02
09004dc to
f8e653c
Compare
Deploying monorepo with
|
| Latest commit: |
f8e653c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d2190c62.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://revamped-marshal-exact-acqui.monorepo-eu0.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marshal resolves each requested full commitment through exact local lookup or shared resolver demand. A request stays live until delivery or its last caller cancels; cancellation preserves independent round and height repair interests. This removes digest fallbacks, targeted hints and certificate-delivery machinery.
Standard and Coding use the new acquisition API while retaining their existing backward history traversal. Their existing parent providers already know the full commitment, so their migration is a direct call-site change. Exact decoding, certification, pruning and cancellation tests land with this backend. Speculative prefetch follows in the next layer.
Stack (4/7): #4874 -> #4875 -> #4876 -> #4878 -> #4879 -> #4880 -> #4722.
Extracted from #4722 at
4735c16d0; each PR is compared with the preceding branch. Follow-up corrections are folded into the layer that owns the mechanism.Validation: All 1,404 default-profile Consensus/Glue tests and formatting passed on current main (365 tests skipped). One aggregation process-leak diagnostic passed a clean isolated rerun.
Counts are gross added/deleted lines against this PR's base, including comments and blank lines. Test infrastructure includes test/mock/benchmark files and inline test-only items; remaining lines are production.