Skip to content

[consensus/marshal] Acquire blocks by exact commitment - #4878

Draft
patrick-ogrady wants to merge 1 commit into
revamped-marshal-dkg-boundariesfrom
revamped-marshal-exact-acquisition
Draft

patrick-ogrady wants to merge 1 commit into
revamped-marshal-dkg-boundariesfrom
revamped-marshal-exact-acquisition

Conversation

@patrick-ogrady

@patrick-ogrady patrick-ogrady commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Marshal resolves each requested full commitment through exact local lookup or shared resolver demand. A request stays live until delivery or its last caller cancels; cancellation preserves independent round and height repair interests. This removes digest fallbacks, targeted hints and certificate-delivery machinery.

Standard and Coding use the new acquisition API while retaining their existing backward history traversal. Their existing parent providers already know the full commitment, so their migration is a direct call-site change. Exact decoding, certification, pruning and cancellation tests land with this backend. Speculative prefetch follows in the next layer.

Stack (4/7): #4874 -> #4875 -> #4876 -> #4878 -> #4879 -> #4880 -> #4722.

Extracted from #4722 at 4735c16d0; each PR is compared with the preceding branch. Follow-up corrections are folded into the layer that owns the mechanism.

Validation: All 1,404 default-profile Consensus/Glue tests and formatting passed on current main (365 tests skipped). One aggregation process-leak diagnostic passed a clean isolated rerun.

Changed lines Added Deleted
Production 420 1,782
Tests / test infrastructure 1,352 3,052

Counts are gross added/deleted lines against this PR's base, including comments and blank lines. Test infrastructure includes test/mock/benchmark files and inline test-only items; remaining lines are production.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 21, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
commonware-mcp f8e653c Sep 21 2026, 06:02 AM

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

Benchmark results

Regressions: 0.

✅ `qmdb::merkleize/v=any::unordered::fixed::mmr k=10000 ch=false s=true cc=true` (2/2 gates passed)
Field Value
Package commonware-storage
Benchmark target qmdb_gungraun
Variant qmdb::merkleize/v=any::unordered::fixed::mmr k=10000 ch=false s=true cc=true
Filter *::bench_merkleize::any_unordered_fixed_mmr
Baseline suite commonware-storage
Gates EstimatedCycles should decrease; tolerance 10.00%; blob_reads should decrease; tolerance 10.00%
Cargo flags --features test-traits
Metric Baseline Current Delta Gate
Ir 13,417,110 13,361,290 -0.42% -
L1hits 17,209,109 17,142,876 -0.38% -
LLhits 113,231 102,730 -9.27% -
RamHits 5,038 4,886 -3.02% -
TotalRW 17,327,378 17,250,492 -0.44% -
EstimatedCycles 17,951,594 17,827,536 -0.69% EstimatedCycles should decrease; tolerance 10.00%
blob_reads 158 158 +0.00% blob_reads should decrease; tolerance 10.00%
✅ `qmdb::merkleize/v=current::ordered::fixed::mmb chunk=256 k=10000 ch=false s=true cc=true` (2/2 gates passed)
Field Value
Package commonware-storage
Benchmark target qmdb_gungraun
Variant qmdb::merkleize/v=current::ordered::fixed::mmb chunk=256 k=10000 ch=false s=true cc=true
Filter *::bench_merkleize::current_ordered_fixed_mmb_chunk_256
Baseline suite commonware-storage
Gates EstimatedCycles should decrease; tolerance 10.00%; blob_reads should decrease; tolerance 10.00%
Cargo flags --features test-traits
Metric Baseline Current Delta Gate
Ir 15,721,105 15,644,270 -0.49% -
L1hits 20,739,147 20,554,965 -0.89% -
LLhits 152,842 134,657 -11.90% -
RamHits 17,875 17,732 -0.80% -
TotalRW 20,909,864 20,707,354 -0.97% -
EstimatedCycles 22,128,982 21,848,870 -1.27% EstimatedCycles should decrease; tolerance 10.00%
blob_reads 235 235 +0.00% blob_reads should decrease; tolerance 10.00%

Baseline commit(s): 90a8b32888b1

@patrick-ogrady
patrick-ogrady force-pushed the revamped-marshal-exact-acquisition branch from 09004dc to f8e653c Compare September 21, 2026 06:02
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 21, 2026

Copy link
Copy Markdown

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: f8e653c
Status: ✅  Deploy successful!
Preview URL: https://d2190c62.monorepo-eu0.pages.dev
Branch Preview URL: https://revamped-marshal-exact-acqui.monorepo-eu0.pages.dev

View logs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant