[consensus/simplex] Supply selected commitments to applications - #4875
Draft
patrick-ogrady wants to merge 1 commit into
Draft
patrick-ogrady wants to merge 1 commit into
patrick-ogrady wants to merge 1 commit into
Conversation
This was referenced Sep 21, 2026
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 13343b2 | Sep 21 2026, 05:59 AM |
patrick-ogrady
added this pull request to stack #4877
September 21, 2026 04:55
Benchmark resultsRegressions: ✅ `qmdb::merkleize/v=any::unordered::fixed::mmr k=10000 ch=false s=true cc=true` (2/2 gates passed)
✅ `qmdb::merkleize/v=current::ordered::fixed::mmb chunk=256 k=10000 ch=false s=true cc=true` (2/2 gates passed)
Baseline commit(s): |
This was referenced Sep 21, 2026
patrick-ogrady
removed this pull request from stack #4877
September 21, 2026 05:44
patrick-ogrady
added this pull request to stack #4881
September 21, 2026 05:44
patrick-ogrady
force-pushed
the
revamped-marshal-selected-commitments
branch
from
September 21, 2026 05:58
50b0650 to
13343b2
Compare
Deploying monorepo with
|
| Latest commit: |
13343b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d92e0071.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://revamped-marshal-selected-co.monorepo-eu0.pages.dev |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## revamped-marshal-block-ranges #4875 +/- ##
================================================================
Coverage 95.77% 95.77%
================================================================
Files 639 639
Lines 299331 300623 +1292
Branches 7369 7401 +32
================================================================
+ Hits 286680 287935 +1255
- Misses 10297 10315 +18
- Partials 2354 2373 +19
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplex now supplies shared selected commitments to proposal, verification and certification requests. It validates the selected path, collapses consecutive reproposals, and repairs missing certified ancestry before consuming a request. Certification receives its own ancestry even when there was no prior local verification.
All Automaton implementations and existing test callers accept the expanded interface. Marshal's adapters begin consuming the new parameter in the application migration layer. The Simplex implementation and its regression tests include the follow-up corrections from the original PR.
The existing Marshal tests need ancestry arguments at this boundary. Of their 130 migrated calls, 77 use the final argument expression and 53 use valid selected-chain expressions until the corresponding legacy tests are rewritten or removed in the exact-acquisition layer. This adds no temporary production helper or test.
Stack (2/7): #4874 -> #4875 -> #4876 -> #4878 -> #4879 -> #4880 -> #4722.
Extracted from #4722 at
4735c16d0; each PR is compared with the preceding branch. Follow-up corrections are folded into the layer that owns the mechanism.Validation: All 1,417 default-profile Consensus/Glue tests and formatting passed on current main (365 tests skipped).
Counts are gross added/deleted lines against this PR's base, including comments and blank lines. Test infrastructure includes test/mock/benchmark files and inline test-only items; remaining lines are production.