Skip to content

Cleanup within HCAL TPG Coder Realm - #51808

Open
JHiltbrand wants to merge 1 commit into
cms-sw:masterfrom
JHiltbrand:cleanupHcalTPGCoder_201X
Open

Cleanup within HCAL TPG Coder Realm#51808
JHiltbrand wants to merge 1 commit into
cms-sw:masterfrom
JHiltbrand:cleanupHcalTPGCoder_201X

Conversation

@JHiltbrand

@JHiltbrand JHiltbrand commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

PR description:

Following in the same spirit as #51764, looking to clean up things now in *HcalTPG*-related packages, which concerns instantiation of in-memory input (linearization) and output (compression) look-up tables for TP formation. No breaking of any sort of backwards-compatibility is intended. Likewise, no changes in TP outputs are intended. Some highlights of changes include:

  • Removed the CalibCalorimetry/HcalTPGIO package in its entirety as it is seemingly not used anywhere.
  • Decoupled HcaluLUTTPGCoder from the custom XML-handling code (coder builds in-memory LUTs exclusively from conditions database) in CalibCalorimetry/HcalTPGAlgos, and moved said XML-handling code to CaloOnlineTools/HcalOnlineDb, where it is exclusively used for producing LUT XML files "offline".

PR validation:

  • Builds with all package dependencies checked out
  • Standalone HCAL XML LUT workflows work as usual
  • Basic HCAL TP re-emulation cmsRun process runs without issue

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No need for a backport to any previous cycle.

@cmsbuild

cmsbuild commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

cmsbuild commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild

cmsbuild commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @JHiltbrand for master.

It involves the following packages:

  • CalibCalorimetry/CaloTPG (alca, l1)
  • CalibCalorimetry/HcalTPGAlgos (alca, l1)
  • CalibCalorimetry/HcalTPGEventSetup (alca, l1)
  • CalibCalorimetry/HcalTPGIO (alca, l1)
  • CalibFormats/CaloTPG (alca)
  • CalibFormats/HcalObjects (alca)
  • CaloOnlineTools/HcalOnlineDb (db)
  • SimCalorimetry/HcalTrigPrimProducers (l1)

@Alejandro1400, @BenjaminRS, @EltonSh, @JanChyczynski, @arunhep, @cmsbuild, @francescobrivio, @perrotta, @quinnanm can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @ReyerBand, @abdoulline, @bsunanda, @missirol, @mmusich, @rovere, @sameasy, @thomreis, @tocheng, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@perrotta

perrotta commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

please test

@cmsbuild

cmsbuild commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 64KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fd33e/55672/summary.html
COMMIT: 27b0dcb
CMSSW: CMSSW_20_1_X_2026-09-02-2300/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51808/55672/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3592269
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3592218
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@perrotta

perrotta commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

+1

@cmsbuild

cmsbuild commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild

cmsbuild commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Pull request #51808 was updated. @Alejandro1400, @BenjaminRS, @EltonSh, @JanChyczynski, @arunhep, @cmsbuild, @francescobrivio, @perrotta, @quinnanm can you please check and sign again.

@JHiltbrand

Copy link
Copy Markdown
Contributor Author

Rebased following yesterday's merging of #51818.

@perrotta

perrotta commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

+1

  • Just rebased after previous signature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants