Cleanup within HCAL TPG Coder Realm - #51808
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51808/50800 |
|
A new Pull Request was created by @JHiltbrand for master. It involves the following packages:
@Alejandro1400, @BenjaminRS, @EltonSh, @JanChyczynski, @arunhep, @cmsbuild, @francescobrivio, @perrotta, @quinnanm can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Size: This PR adds an extra 64KB to repository Comparison SummarySummary:
|
|
+1 |
27b0dcb to
f0df509
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51808/50875 |
|
Pull request #51808 was updated. @Alejandro1400, @BenjaminRS, @EltonSh, @JanChyczynski, @arunhep, @cmsbuild, @francescobrivio, @perrotta, @quinnanm can you please check and sign again. |
|
Rebased following yesterday's merging of #51818. |
|
+1
|
PR description:
Following in the same spirit as #51764, looking to clean up things now in
*HcalTPG*-related packages, which concerns instantiation of in-memory input (linearization) and output (compression) look-up tables for TP formation. No breaking of any sort of backwards-compatibility is intended. Likewise, no changes in TP outputs are intended. Some highlights of changes include:CalibCalorimetry/HcalTPGIOpackage in its entirety as it is seemingly not used anywhere.HcaluLUTTPGCoderfrom the custom XML-handling code (coder builds in-memory LUTs exclusively from conditions database) inCalibCalorimetry/HcalTPGAlgos, and moved said XML-handling code toCaloOnlineTools/HcalOnlineDb, where it is exclusively used for producing LUT XML files "offline".PR validation:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
No need for a backport to any previous cycle.