[Phase2 L1T] GMT Upgrade of Kalman Filter for Barrel Muon KMTF by zhenbinwu · Pull Request #51111 · cms-sw/cmssw

zhenbinwu · 2026-06-01T21:44:09Z

PR description:

Extend the Kalman Muon Barrel Track Finding algorithm for more precise measurements of track eta and z
Making use of new dataformat of Phase2 DT, Phi-Theta matched pairs
Detail in talk

PR validation:

Validated

KMTFTrack now requires z, kSlope as arguments added z, kSlope members and accessors setCoordinates, setCovariance now require arguments z, kSlope

…new gain LUTs now for z, kSlope

cmsbuild · 2026-08-07T16:03:43Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-911f60/55166/summary.html
COMMIT: 83937d9
CMSSW: CMSSW_20_1_X_2026-08-07-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51111/55166/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test test_dqm-plot had ERRORS

Comparison Summary

Summary:

You potentially added 8 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3589140
DQMHistoTests: Total failures: 238
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3588884
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 195 log files, 163 edm output root files, 45 DQM output files
TriggerResults: no differences found

quinnanm · 2026-08-11T20:01:43Z

please test with cms-data/L1Trigger-Phase2L1GMT#2

cmsbuild · 2026-08-11T21:55:42Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-911f60/55257/summary.html
COMMIT: 83937d9
CMSSW: CMSSW_20_1_X_2026-08-11-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51111/55257/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@felicepantaleo RecoEgamma: drop the TICLGeom ES producers from the HGC egamma PAT task #51668

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-911f60/55257/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-911f60/55257/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

You potentially added 9 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3433258
DQMHistoTests: Total failures: 230
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3433010
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 191 log files, 159 edm output root files, 44 DQM output files
TriggerResults: found differences in 1 / 43 workflows

quinnanm · 2026-08-12T00:15:45Z

it is showing changed trigger results for TkEls between CMSSW_20_1_X_2026-08-07-1100 and CMSSW_20_1_X_2026-08-11-1100, very likely because of the geometry change. the unit test failure seems like something intermittent (X509 proxy) so ill give it another try

quinnanm · 2026-08-12T00:16:21Z

please test with cms-data/L1Trigger-Phase2L1GMT#2

cmsbuild · 2026-08-12T02:15:24Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-911f60/55264/summary.html
COMMIT: 83937d9
CMSSW: CMSSW_20_1_X_2026-08-11-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51111/55264/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 8 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3433258
DQMHistoTests: Total failures: 181
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3433059
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 191 log files, 159 edm output root files, 44 DQM output files
TriggerResults: no differences found

zhenbinwu · 2026-08-12T02:31:52Z

Thanks Melissa! It seems OK now.

quinnanm · 2026-08-12T09:12:20Z

+l1

cmsbuild · 2026-08-12T09:12:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/L1Trigger-Phase2L1GMT#2

mandrenguyen · 2026-08-13T06:51:25Z

The PR description says that the PR validation is "ongoing...". What does that mean? We wait to merge this until it's clarified.

zhenbinwu · 2026-08-13T14:20:09Z

Updated the comment. It is validated. Thanks

mandrenguyen · 2026-08-13T19:31:13Z

+1

delanocamposs added 23 commits February 27, 2026 19:57

Merged AMv2.3 from repository jfernan2 with cms-merge-topic

7f7c6b0

bitshift bug fix KMTF.cc

a99796d

New typedef for 5 dimensional covariance matrix

584d706

KMTFTrack now requires z, kSlope as arguments added z, kSlope members and accessors setCoordinates, setCovariance now require arguments z, kSlope

new class version for KMTFTrack.h update version 4.

76a32a8

initial development commits

e98e4a9

symmetrix matrix fix

e514aeb

matrix vector fix

e5b0f3c

revert matrix vector argument to upper triangle only

afc1d61

verbose = 1

edee2c8

testing new z prop wheel-based logic

d62af54

more verbose print statements

8ed52d9

printout changes

e84f5c7

fix initial covariances

2c29220

kSlope point resolution

4b648c6

previous propagation residuals

93259fa

latest

d9dbe79

reverting back to using kSlope in measurement space for residual

63e041e

tests

1c15a25

testing

13ff919

testing

629bb34

updates

2172930

add new members and accessors for new gain values

3bc97b4

fixed point arithmetic for zNew and kSlope. updateLUT function pulls …

66d9d59

…new gain LUTs now for z, kSlope

cmsbuild added this to the CMSSW_17_0_X milestone Jun 1, 2026

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending changes-dataformats labels Jun 1, 2026

cmsbuild added tests-started requires-external and removed tests-pending labels Aug 7, 2026

cmsbuild added tests-rejected and removed tests-started labels Aug 7, 2026

cmsbuild added tests-started and removed tests-rejected labels Aug 11, 2026

cmsbuild added tests-rejected and removed tests-started labels Aug 11, 2026

cmsbuild added tests-started and removed tests-rejected labels Aug 12, 2026

cmsbuild added tests-approved and removed tests-started labels Aug 12, 2026

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Aug 12, 2026

cmsbuild removed the orp-pending label Aug 13, 2026

Navigation Menu

Uh oh!

[Phase2 L1T] GMT Upgrade of Kalman Filter for Barrel Muon KMTF - #51111

[Phase2 L1T] GMT Upgrade of Kalman Filter for Barrel Muon KMTF#51111
cmsbuild merged 34 commits into
cms-sw:masterfrom
zhenbinwu:Kalman_26

zhenbinwu commented Jun 1, 2026 •

edited

Loading

Uh oh!

cmsbuild commented Aug 7, 2026

Uh oh!

quinnanm commented Aug 11, 2026

Uh oh!

cmsbuild commented Aug 11, 2026

Uh oh!

quinnanm commented Aug 12, 2026 •

edited

Loading

Uh oh!

quinnanm commented Aug 12, 2026

Uh oh!

cmsbuild commented Aug 12, 2026

Uh oh!

zhenbinwu commented Aug 12, 2026

Uh oh!

quinnanm commented Aug 12, 2026

Uh oh!

cmsbuild commented Aug 12, 2026

Uh oh!

mandrenguyen commented Aug 13, 2026

Uh oh!

zhenbinwu commented Aug 13, 2026

Uh oh!

mandrenguyen commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

zhenbinwu commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Aug 7, 2026

Failed Unit Tests

Comparison Summary

Uh oh!

quinnanm commented Aug 11, 2026

Uh oh!

cmsbuild commented Aug 11, 2026

Failed Unit Tests

Comparison Summary

Uh oh!

quinnanm commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quinnanm commented Aug 12, 2026

Uh oh!

cmsbuild commented Aug 12, 2026

Comparison Summary

Uh oh!

zhenbinwu commented Aug 12, 2026

Uh oh!

quinnanm commented Aug 12, 2026

Uh oh!

cmsbuild commented Aug 12, 2026

Uh oh!

mandrenguyen commented Aug 13, 2026

Uh oh!

zhenbinwu commented Aug 13, 2026

Uh oh!

mandrenguyen commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

zhenbinwu commented Jun 1, 2026 •

edited

Loading

quinnanm commented Aug 12, 2026 •

edited

Loading