feat: add a cache challenge store for API clients without a session - #152
Draft
RenzoMinelli wants to merge 2 commits into
Draft
RenzoMinelli wants to merge 2 commits into
RenzoMinelli wants to merge 2 commits into
Conversation
RenzoMinelli
added a commit
that referenced
this pull request
Sep 25, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RenzoMinelli
marked this pull request as draft
September 25, 2026 19:04
RenzoMinelli
added a commit
that referenced
this pull request
Sep 25, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RenzoMinelli
force-pushed
the
rm--cache-challenge-store
branch
from
September 25, 2026 19:08
87acce5 to
05d846d
Compare
RenzoMinelli
added a commit
that referenced
this pull request
Sep 25, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RenzoMinelli
force-pushed
the
rm--cache-challenge-store
branch
from
September 25, 2026 19:25
05d846d to
ffe1a99
Compare
RenzoMinelli
force-pushed
the
rm--cache-challenge-store
branch
from
September 25, 2026 20:20
ffe1a99 to
404ae7c
Compare
RenzoMinelli
added a commit
that referenced
this pull request
Sep 25, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RenzoMinelli
added a commit
that referenced
this pull request
Sep 25, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RenzoMinelli
force-pushed
the
rm--cache-challenge-store
branch
from
September 25, 2026 20:34
404ae7c to
9eb1ffd
Compare
RenzoMinelli
added this pull request to stack #156
October 2, 2026 20:17
- `ChallengeStores::Cache` finds the challenge through the credential's clientDataJSON and consumes it once. - Accept `public_key_credential` as a JSON object or string. - Respect `skip_session_storage` (`:params_auth`) in both WebAuthn strategies. - Load the options controllers under an `ActionController::API` parent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RenzoMinelli
force-pushed
the
rm--cache-challenge-store
branch
from
October 2, 2026 22:06
9eb1ffd to
6646a39
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Adds
ChallengeStores::Cache. It finds the challenge through the credential'sclientDataJSONand consumes it once. Also acceptspublic_key_credentialas a JSON object, respectsskip_session_storage(:params_auth), and loads under anActionController::APIparent.Why: This lets mobile clients without cookies sign in with passkeys. A React Native app on an iPhone signed in against a devise-jwt API with this stack.
How to test:
bundle exec rspec spec/requests/devise/api_client_spec.rb spec/devise/webauthn/challenge_stores. The API specs start every request without cookies.