Repository navigation
feat: respond with JSON from the passkey and security key controllers - #153
Draft
RenzoMinelli wants to merge 1 commit into
Draft
RenzoMinelli wants to merge 1 commit into
RenzoMinelli wants to merge 1 commit into
Conversation
RenzoMinelli
force-pushed
the
rm--api-json-responses
branch
from
September 25, 2026 18:48
96e263c to
0ec1357
Compare
RenzoMinelli
marked this pull request as draft
September 25, 2026 19:04
RenzoMinelli
force-pushed
the
rm--api-json-responses
branch
from
September 25, 2026 19:10
0ec1357 to
668139c
Compare
RenzoMinelli
force-pushed
the
rm--api-json-responses
branch
from
September 25, 2026 19:28
668139c to
f1bfdb1
Compare
RenzoMinelli
force-pushed
the
rm--api-json-responses
branch
from
September 25, 2026 20:23
f1bfdb1 to
0502465
Compare
RenzoMinelli
force-pushed
the
rm--api-json-responses
branch
from
September 25, 2026 20:37
0502465 to
eccecad
Compare
RenzoMinelli
added this pull request to stack #156
October 2, 2026 20:17
RenzoMinelli
force-pushed
the
rm--api-json-responses
branch
from
October 2, 2026 22:08
eccecad to
73a6fd7
Compare
Non-navigational requests get `201`/`204`, or `422` with an `error` message, instead of a redirect. Browsers still get redirects and flashes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RenzoMinelli
force-pushed
the
rm--api-json-responses
branch
from
October 6, 2026 12:26
73a6fd7 to
7f7b572
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: For non-navigational requests, the passkey and security key controllers respond
201/204, or422with anerrormessage, instead of redirecting. Browsers still get redirects and flashes.Why: A mobile app needs to add and delete passkeys through the API. Stacked on #152.
How to test:
bundle exec rspec spec/requests/devise/api_client_spec.rb, the "passkey registration" examples.