Skip to content

fix(browser): use /devtools/page endpoint for all target types including iframes #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
I1Kuz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(browser): use /devtools/page endpoint for all target types including iframes #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1987f4
Fix WebSocket 404 for iframe targets and add support for cross-origin…
I1Kuz Sep 7, 2026
0e52cf6
Update CHANGELOG.md
I1Kuz Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fixed `404 Not Found` WebSocket connection error for `iframe` targets by routing all target connections to `/devtools/page/<target_id>` in `Browser._handle_target_update`.

### Added

### Changed
Expand Down
2 changes: 1 addition & 1 deletion zendriver/core/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ async def _handle_target_update(
new_target = Tab(
(
f"ws://{self.config.host}:{self.config.port}"
f"/devtools/{target_info.type_ or 'page'}" # all types are 'page' internally in chrome apparently
f"/devtools/page" # all types are 'page' internally in chrome apparently
f"/{target_info.target_id}"
),
target=target_info,
Expand Down