fix(browser): use /devtools/page endpoint for all target types including iframes - #275
Open
I1Kuz wants to merge 2 commits into
Open
fix(browser): use /devtools/page endpoint for all target types including iframes#275I1Kuz wants to merge 2 commits into
I1Kuz wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
When Chrome creates targets for cross-origin iframes (Out-Of-Process Iframes / OOPIF),
Browser._handle_target_updatereceives acdp.target.TargetCreatedevent wheretarget_info.type_ == "iframe".The WebSocket connection URL was constructed as:
f"/devtools/{target_info.type_ or 'page'}"This evaluated to
ws://<host>:<port>/devtools/iframe/<target_id>. Attempting to connect to this target resulted in:Chrome DevTools HTTP server only accepts connections under
/devtools/page/<target_id>for all target types (as noted in the author's comment on that line, and as already implemented inBrowser.update_targets).Solution
Browser._handle_target_updateto always use/devtools/page/<target_id>.Tabinstances representingiframetargets to successfully connect via WebSocket and interact with elements inside cross-origin iframes.Also consider exposing a property:
and searching those targets in select_all(include_frames=True) when content_document is null due to cross-origin isolation.
Pre-merge Checklist
./scripts/format.shand./scripts/lint.shscripts. My code is properly formatted and has no linting errors.uv run pytestand ensured all tests pass.[Unreleased]section.