Repository navigation
feat(agc): accept texel offsets, LOD biases and LOD clamps in color comparison sampling - #934
Merged
Conversation
This was referenced Oct 6, 2026
…omparison sampling Comparison sampling of a color texture threw on the _o, _b and _cl forms and on a sampler LOD bias. The emulation fetches the texels itself, so the 6-bit offsets of the address are added to the point or bilinear texel indices, as on the hardware and in Vulkan. The emulation runs only at level zero or on a single-level view, where an LOD bias or clamp cannot select another level, so they are accepted with no effect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Measured I rebased onto |
adriadam10
force-pushed
the
feat/agc-color-compare-offsets
branch
from
October 7, 2026 09:31
8b3d5ee to
2eebe84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Comparison sampling of a color texture threw on the
_o,_band_clforms and on a sampler LOD bias.#907 also edits the color compare emulation, but it is a review follow-up to #668 and doesn't add these forms.
Tested
Windows 11, MinGW GCC Release build, ctest
agc_driver_emulated_color_comparepasses (on the GPU). The test now also runs with point and bilinear filtering for:Each result is compared with a CPU reference that applies the same offsets.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code