Repository navigation
feat(playerinvitationdialog): implement scePlayerInvitationDialogGetResult - #870
Merged
oneandonlydean merged 1 commit intoOct 6, 2026
Conversation
…esult scePlayerInvitationDialogGetResult makes the common dialog checks of sceWebBrowserDialogGetResult: NOT_INITIALIZED before the dialog is initialized, ARG_NULL for a null result and NOT_FINISHED until the dialog finishes. The dialog shows no UI and sends no invitation, so the finished dialog reports USER_CANCELED with error code 0. The 40-byte result layout (error code, result, 32 reserved bytes) is taken from SharpProspero. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9 tasks done
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scePlayerInvitationDialogGetResultwas the last unimplemented export of libScePlayerInvitationDialog. It now makes the common dialog checks ofsceWebBrowserDialogGetResult:NOT_INITIALIZED(0x80B80003) beforescePlayerInvitationDialogInitializeand afterscePlayerInvitationDialogTerminate;ARG_NULL(0x80B8000D) for a null result;NOT_FINISHED(0x80B80005) while the dialog is initialized or running.The dialog shows no UI and sends no invitation, so a finished dialog reports
USER_CANCELEDwith error code 0, and the reserved bytes are cleared.The 40-byte
ScePlayerInvitationDialogResultlayout (error code, result, 32 reserved bytes) comes from SharpProspero'sPlayerInvitationDialog.cs. The existing TechnicalDebt entry for the dialog now records the result and its sources, and the dialog is dropped from the "exports added without an implementation have assumed signatures" line.Tested
BUILD_TESTING=ON, lavapipe.player_invitation_dialog: the result before initialization and after termination, a null result, the result while initialized and while running, and the finished result (error code,USER_CANCELED, cleared reserved bytes over a buffer filled with0xFF). Onmainthe same test stops withscePlayerInvitationDialogGetResult not implemented.ctest: 358 of 359 pass.guest_sce_netalso fails on unmodifiedmainin this environment (its resolver test), unrelated to this change.libScePlayerInvitationDialog.prxexportsAhqlQ8cngrk.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code