Skip to content

feat(libSceWebBrowserDialog): finish PredeterminedContent without UI (PPSA34015) - #6092

Closed
notaxeltv wants to merge 1 commit into
boykopovar:mainfrom
notaxeltv:feat/libSceWebBrowserDialog-predetermined-content
Closed

notaxeltv wants to merge 1 commit into
boykopovar:mainfrom
notaxeltv:feat/libSceWebBrowserDialog-predetermined-content

Conversation

@notaxeltv

Copy link
Copy Markdown
Contributor

What

sceWebBrowserDialogOpenForPredeterminedContent was a stub that throws. Match sceWebBrowserDialogOpen: finish immediately with no browser UI so GetResult reports user canceled. Silent stubs listed in docs/dev/debt/libSceWebBrowserDialog.md. PPSA34015 imports it (tools/import_audit.py stub).

Tested

Windows 10, WinLibs GCC 15.2.0, guest_web_browser_dialog passes. tools/check_conventions.py --base upstream/main passes.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source (none)
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: PPSA34015 (stub import)
  • GPUs tested: n/a
  • AI-assisted: yes

Made with Cursor

Same cancel-at-once path as Open; list silent stubs in debt.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown

Progress report (153d5d4 → b752400)

📈 System libraries: 88.72% (+0.03%, +1 implemented functions)

✅ 1 implemented
Library Name
libSceWebBrowserDialog sceWebBrowserDialogOpenForPredeterminedContent

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.

Pull request Conflicting files (lines on main) Same exports Same new files
PR 5904 core/libs/prx/libSceWebBrowserDialog/Export.cpp L75-76
core/libs/tests/GuestWebBrowserDialog.cpp L8, L66
docs/dev/debt/libSceWebBrowserDialog.md
docs/dev/debt/libSceWebBrowserDialog.md
PR 6361 docs/dev/debt/libSceWebBrowserDialog.md docs/dev/debt/libSceWebBrowserDialog.md
PR 6447 docs/dev/debt/libSceWebBrowserDialog.md

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 6044 core/libs/tests/GuestWebBrowserDialog.cpp
PR 6447 core/libs/prx/libSceWebBrowserDialog/Export.cpp
docs/dev/debt/libSceWebBrowserDialog.md

@coltken95

Copy link
Copy Markdown

Tested on Linux x86-64 (Release build), with b752400 merged into main 8cd937e:

  • With the PR: guest_web_browser_dialog passes.
  • With main's libSceWebBrowserDialog/Export.cpp: guest_web_browser_dialog aborts with what(): sceWebBrowserDialogOpenForPredeterminedContent not implemented.

AI-assisted: yes (Claude Code)

@notaxeltv

Copy link
Copy Markdown
Contributor Author

Closing to free intake for title-blocking AGC work (PPSA03541). Can reopen after merges if still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants