Repository navigation
fix(libSceWebBrowserDialog): return error codes instead of throwing in initialize and terminate - #5715
Merged
adriadam10 merged 1 commit intoOct 15, 2026
Conversation
…n initialize and terminate
11 tasks done
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
11 tasks done
Collaborator
|
Checked the new return codes ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sceWebBrowserDialogInitializepreviously threwstd::logic_errorif already initialized, andsceWebBrowserDialogTerminatepreviously threw if called when uninitialized. In common dialogs, these conditions should return error codes instead of throwing exceptions:sceWebBrowserDialogInitializereturns0x80B80004(COMMON_DIALOG_ERROR_ALREADY_INITIALIZED) when already initialized.sceWebBrowserDialogTerminatereturns0x80B80003(COMMON_DIALOG_ERROR_NOT_INITIALIZED) when uninitialized, andCOMMON_DIALOG_ERROR_BUSYwhen not in a terminable state.Also removes unused
<stdexcept>include and updatesGuestWebBrowserDialogguest tests to verify these error code returns.Tested
python tools/check_conventions.py --base upstream/mainpassed.python tools/check_test_registration.pypassed (707 test executables).Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)