Repository navigation
docs: fix Pages workflow link and separate library technical debt - #6039
mariusyo07 wants to merge 2 commits into
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
The new PR 5911 also edits |
- docs/dev/PROGRESS.md: update Progress workflow link to point to pages.yml. - docs/dev/debt/libSceNetCtl.md: move unkeyed sceNetCtlGetIfStat debt entry from TechnicalDebt.md to libSceNetCtl.md with link to Export.cpp. - docs/dev/debt/libSceNpSessionSignaling.md: move sceNpSessionSignalingGetGroupFromSessionId from libSceSsl.md to libSceNpSessionSignaling.md.
c45b5eb to
bda2614
Compare
adriadam10
left a comment
There was a problem hiding this comment.
Thanks for this. It now conflicts with main, and part of it is obsolete:
docs/dev/debt/libSceSsl.md:mainremoved the### Functionalsection, sincesceSslEnableVerifyOptionis implemented now, so the conflict is real.docs/dev/debt/libSceJson2.mdline 13 onmainalready holds the whole PPSA07411 entry (the foursce::Json::Valuemembers,sceConvertKeycodeGetCharacterandsceNpSessionSignalingGetGroupFromSessionId), so the new Json2 line and the newlibSceNpSessionSignaling.mdline would duplicate it.
Please rebase on main and drop those hunks (libSceJson2.md, libSceNpSessionSignaling.md, libSceSsl.md). The rest is fine and still needed: the PROGRESS.md link (progress.yml doesn't exist, pages.yml does) and moving sceNetCtlGetIfStat from TechnicalDebt.md to debt/libSceNetCtl.md. With only those two it should be mergeable.
What
Fixes 3 documentation and technical debt issues:
docs/dev/PROGRESS.md: Points to.github/workflows/pages.yml(Pages workflow) instead of the non-existentprogress.yml.libSceNetCtltechnical debt: Moves the unkeyedsceNetCtlGetIfStattechnical debt entry fromdocs/dev/TechnicalDebt.mdtodocs/dev/debt/libSceNetCtl.mdwith its markdown link tocore/libs/prx/libSceNetCtl/Export.cpp, in accordance with the convention that library-specific debt resides indocs/dev/debt/<library>.md.libSceNpSessionSignalingtechnical debt: MovessceNpSessionSignalingGetGroupFromSessionId(imported by PPSA07411, declared without parameters and unimplemented incore/libs/prx/libSceNpSessionSignaling/Export.cpp) fromdocs/dev/debt/libSceSsl.mdtodocs/dev/debt/libSceNpSessionSignaling.mdunder### Unknown function info, and updateslibSceSsl.mdto cleanly describe onlysceSslEnableVerifyOption.Tested
python3 tools/check_conventions.py --base upstream/main: all conventions checks passed.git diff --check: passes with no whitespace or style warnings.python3 tools/pr_overlap.py --branch docs/workflow-link-and-debt-cleanup: no overlap with open pull requests.python3 -m unittest discover -s tools/tests: 399 tests ran, all passed (2 expected skips).python3 tools/check_main_sync.py: clean merge againstupstream/main.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)