Repository navigation
Conversation
Merged
11 tasks done
bcortezf
force-pushed
the
feat/audioout-get-system-state
branch
from
October 14, 2026 19:08
ca17d07 to
8f22c85
Compare
11 tasks done
Author
|
could someone check this? @adriadam10 |
11 tasks done
bcortezf
force-pushed
the
feat/audioout-get-system-state
branch
from
October 14, 2026 23:36
8f22c85 to
46cd6d5
Compare
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This was referenced Oct 15, 2026
Open
This was referenced Oct 15, 2026
adriadam10
requested changes
Oct 16, 2026
adriadam10
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. Build and the AudioOut ctest scope are green here, and audio_out_system_state fails to build without the change. One thing to fix:
core/libs/SceTypes.hpp:575AudioOutSystemStateis 64 bytes (copied fromAudioOut2SystemState), but the sources the debt line cites say 32: shadPS4'sOrbisAudioOutSystemStateisfloat loudness; u8 reserved8[4]; u64 reserved64[3], and SharpProspero'sSceAudioOutSystemStatehasSize = 32. Please use the 32-byte layout (std::uint64_t reserved[3]), and add astatic_assert(sizeof(...) == 32).docs/dev/debt/libSceAudioOut.md:15: the layout is not from shadPS4/fpPS4 as written, so correct it once the struct matches. Also note there that shadPS4 returns NOT_INIT before init (not modelled) and that SharpProspero documents loudness in LKFS, so the constant0.0fis unconfirmed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Red Dead Redemption (PPSA30528) imports
sceAudioOutGetSystemState(NIDR5hemoKKID8) and fails to load without it:This PR adds it with the same behaviour as the existing
sceAudioOut2GetSystemState:floatloudness, padding and reserved words) and reports a loudness of0.0f.0x80260004, like the other AudioOut calls.The signature and layout come from the shadPS4 and fpPS4 reimplementations, not from a console measurement. They are recorded under "Unknown function info" in
docs/dev/debt/libSceAudioOut.md.A unit test (
audio_out_system_state) checks the result, the loudness and the null pointer.Tested
Windows 11 (10.0.26200), MinGW build
ctest -R audio_out_system_statepasses.python3 tools/check_conventions.py --base origin/mainpasses.maina0f5916 plus this commit, together with separate local rendering workarounds that are not part of this PR. On currentmain, a fresh run of the title also needs its executable converted again with the current relinker, which I have not redone.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)