Repository navigation
fix(libSceVideoOut): return VIDEO_OUT_ERROR_INVALID_VALUE for a flip rate outside 0..2 - #5691
Conversation
…rate outside 0..2 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@adriadam10 a single, short request for review of our five open pull requests (all
Thank you for the reviews and merges on #4778, #5020 and #5143. No reply is needed beyond whatever review you see fit; I will not post a second request. AI-assisted (Claude Code). |
|
Checked: the full diff, |
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
What
PPSA13356 (Raiden III) calls
sceVideoOutSetFlipRate(handle, 60)at start-up.sceVideoOutSetFlipRateaccepted only 0, 1 and 2 and threw for any other rate, so the title aborted:(
PPSA13356_rU/run_081948.errlines 8-9,main+ #5038, without this change; the rate 60 was read with a local log line inPPSA13356_rR/run_080252.errline 6.)The function now returns
VIDEO_OUT_ERROR_INVALID_VALUEfor a rate outside 0..2 and leaves the stored rate unchanged.76e5edcac) + libScePad: replace NotImplemented stubs and fix return-0 consistency #5038 the run no longer stops atsceVideoOutSetFlipRate; it goes on and ends at a different place,what(): NGS2: invalid voice handle(PPSA13356_rV/run_083704.errlines 29-30, and in two repeatsrun_083940.err,run_084444.err). That stop is not part of this pull request.VIDEO_OUT_ERROR_INVALID_VALUEfor it. There is no source for it in the repository. The change relies on the title tolerating the error;docs/dev/debt/libSceVideoOut.mdhas an entry that says so.scePadUnknown_n3kSX62fgNo(libScePad: replace NotImplemented stubs and fix return-0 consistency #5038) has to be merged for PPSA13356 to reach this call; this change does not depend on it in code.Tested
Windows 10 (19045), MinGW-w64 GCC 15.2.0, Release. Branch rebased onto
main1e7272196(two commits, no merge):video_out_flip_tests controls(changed: callssceVideoOutSetFlipRatewith 3, 60 and -1, expectsVIDEO_OUT_ERROR_INVALID_VALUEand an unchanged stored rate) passes with this change; the other four flip tests (lifetime,reopen,overlay,unopened) pass too. They ran withSDL_VIDEODRIVER=windowson an RTX 4080 SUPER, because under ctest the SDL driver isoffscreenand the tests are skipped.Output.cpp(taken frommain, test kept)controlsfails:sceVideoOutSetFlipRate: VIDEO_OUT_ERROR_INVALID_VALUE, exit code 1.python tools/check_conventions.py --base upstream/mainwith this title and body passes.76e5edcac+ libScePad: replace NotImplemented stubs and fix return-0 consistency #5038 (merge6a4d76b8e); librariesninja -C build -j4 relinkerplus all 126core/libs/libs/*.prxof that tree, finished 08:36:53 local time (libSceAgcDriver.prx08:36:23);relinker.exe2026-10-14 07:35:29;app.exerelinked 08:37:00 withrelink_title_trace.ps1 -Repo K:\AnyPS5\wt-sockets(relinker.exe --windows --registry --trace-imports, no-ModuleDir); runrun_title.ps1 -Seconds 90. Result: pastSetFlipRate, thenNGS2: invalid voice handleas above.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt (docs/dev/debt/libSceVideoOut.md).mdfiles or images added to the repositorysceVideoOutSetFlipRate; no bring-up discussion known to meAI-assisted (Claude Code).
🤖 Generated with Claude Code