Skip to content

fix(agc): skip an indexed draw with no indices or instances - #5205

Merged
oneandonlydean merged 2 commits into
boykopovar:mainfrom
mrfelek:pr/skip-zero-count-indexed-draw
Oct 14, 2026
Merged

oneandonlydean merged 2 commits into
boykopovar:mainfrom
mrfelek:pr/skip-zero-count-indexed-draw

Conversation

@mrfelek

@mrfelek mrfelek commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

What

A direct indexed draw with zero indices or zero instances threw zero-count indexed draws are unsupported. The auto (non-indexed) path already records nothing for such a draw. The indexed path now does the same: the draw has nothing to rasterize, so no work is recorded. Indirect draws are unchanged.

New case in agc_driver_graphics_tests: an indexed draw with zero indices and one with zero instances are skipped. The zero-index case fails without the change with "an indexed draw without indices was not skipped".

Tested

Ubuntu 26.10, GCC 15.3.0, RTX 3080 Ti (NVIDIA 615.71.09), Release, on main 146f171.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw; no silent stubs added
  • No notes, investigation .md files or images added to the repository
  • New third-party code is a submodule built from source (none)
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: PPSA03912 Diablo II: Resurrected (PPSA03912) #5146
  • GPUs tested: NVIDIA GeForce RTX 3080 Ti, driver 615.71.09, Ubuntu 26.10
  • AI-assisted: yes (Claude Code); I reviewed every line and ran the tests and the title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agc libSceAgc*

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants