Repository navigation
fix(agc): skip an indexed draw with no indices or instances - #5205
Merged
oneandonlydean merged 2 commits intoOct 14, 2026
Merged
Conversation
4 tasks done
This was referenced Oct 13, 2026
This was referenced Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A direct indexed draw with zero indices or zero instances threw
zero-count indexed draws are unsupported. The auto (non-indexed) path already records nothing for such a draw. The indexed path now does the same: the draw has nothing to rasterize, so no work is recorded. Indirect draws are unchanged.New case in
agc_driver_graphics_tests: an indexed draw with zero indices and one with zero instances are skipped. The zero-index case fails without the change with "an indexed draw without indices was not skipped".Tested
Ubuntu 26.10, GCC 15.3.0, RTX 3080 Ti (NVIDIA 615.71.09), Release, on main 146f171.
agc_driver_graphics_testspasses; fails without the change.Checklist
main; no other open PR implements the same functions.mdfiles or images added to the repository