Repository navigation
feat(agc): storage image access to depth planes through a 2D array view from a later slice - #5779
Conversation
…ew from a later slice A storage view of the depth plane that starts above slice 0 was refused. The layered storage image already spans slices 0..last, and the view starts at its base slice, so the refusal is dropped and only the slices from the base slice to the last are copied in and out. The base slice joins the cache key. DepthStorageDispatch stores through a view from base slice 2 and checks the other slices stay untouched; it fails without the change.
|
Check on today's In game, measured on the third run: 39.1 presents per 10 s (windows 40, 39, 39, 39, 39, 39, 39). The depth tests pass on the combination (9 of 9 AI-assisted; the runs are from my machine. |
|
Checked on Linux (AMD, RADV): |
What
A storage view of a depth plane that starts above slice 0 (a 2D array T# with BASE_ARRAY above 0) threw
storage image access to the depth planes of depth surface ... through a 2D array view of slices N-M is not implemented. #5003 added storage views of depth planes from slice 0 and still refuses these.LayeredDepthStoragealready spans slices 0..last, so the view only needs to know where it starts. The refusal is dropped, the first layer joins the object, and only the slices from the base slice to the last are copied in and out of the depth surfaces. The base slice is part of the cache key, so two views of the same memory from different base slices are separate images, as other views of the same plane already are. The technical-debt entry is updated.Tests:
agc_driver_depth_storage_dispatchnow stores through a view from base slice 2 and checks that the other slices stay untouched;agc_driver_depth_storageno longer expects the refusal. Both fail without the change.Tested
Ubuntu 26.10, GCC 15.3.0, RTX 3080 Ti (NVIDIA 615.71.09), Release, on main c654b19.
agc_driver_depth_storageandagc_driver_depth_storage_dispatchpass, and fail with the source change reverted;agc_driver_depth_storage_reuse,depth_plane_sampling,depth_plane_guest_layers,depth_compare_copyanddepth_fast_clear_submitpass.Checklist
main; no other open PR implements the same functions.mdfiles or images added to the repositoryAI-assisted; the runs are from my machine.