Repository navigation
feat(libc): implement the double nextafter export - #2963
Closed
Prophet069 wants to merge 1 commit into
Closed
Prophet069 wants to merge 1 commit into
Prophet069 wants to merge 1 commit into
Conversation
|
Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes. |
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Provide the missing double-precision
nextafterguest export throughstd::nextafter. Tests check adjacent values, signed zero, NaNs, infinities, subnormal boundaries, errno and floating-point exceptions. This intentionally does not add nextafterf, which is already proposed in #2934.Tested
Windows: affected libc built from this branch with a standalone CMake driver using the repository libc target; functional CTest
guest_nextafterpassed. Linux/macOS and full-project CI not run. This supersedes only the double-precision portion of the closed #1806; no upstream runtime-crash claim is made.Base:
3cb317fcfd877f93b0b65adbe7b737ba1ba5123f; candidate:f50a480dc22f8334ef4b21f40251d58b86f5a268.python tools/check_conventions.py --base origin/mainpassed.Checklist
main; no other open PR implements the same functionsTests were run on1476f769 and retained across the conflict-free rebase to3cb317fc. That upstream interval does not change the tested libc/decoder/IR sources. No game was started for this submission.