Repository navigation
feat(libc): implement the double nextafter export - #5418
Prophet069 wants to merge 1 commit into
Conversation
|
Independent Linux validation of Ubuntu 26.04.1 x86-64, GCC 15.2.0, Release, bundled dependencies,
The value oracle follows C11 draft N1570, sections 7.12.11.3 and F.10.8.3. These are synthetic Linux checks, not console measurements or a title run. No additional Windows/macOS testing or full CTest-suite claim. AI-assisted validation/report: Codex. No changes were made to your implementation. |
There was a problem hiding this comment.
The implementation itself looks fine. The description doesn't name a title that imports nextafter, though. Since #1205/#1208/#950, reviewers ask new-export PRs for the title ID and the log line where that title stops at the export on main (FAIL: unresolved ELF import ... from libc.prx), and export-only PRs without one have been closed. If you know of a title that reaches it (tools/import_audit.py over a title's imports will show it), adding that to the description should be all that's missing.
|
Closing: no title is known to reach this. With the queue at 700+ open PRs, please hold off on new PRs that don't name a title needing the change until it's down. If a title stops on this on current main, reopen with the title ID and the log line. |
|
PPSA02015 reaches it |
What
Provide the missing double-precision
nextafterguest export throughstd::nextafter. Tests check adjacent values, signed zero, NaNs, infinities, subnormal boundaries, errno and floating-point exceptions. This intentionally does not add nextafterf, which is already proposed in #2934.Replaces the obsolete base of closed #2963, which was automatically closed for intake pause. Closed alternatives #4133/#4146 remain unmerged; this draft is for reviewing our existing PR rather than opening another duplicate.
Tested
Windows 10 Pro 22H2 x64 (build 19045), MinGW GCC 15.2.0: built the complete candidate libc.prx from this branch and ran the functional
guest_nextafterregression successfully. Tests use synthetic guest-ABI inputs; no game startup, Linux/macOS build or maintainer CI run is claimed.Based on main
dacd78525e537a779682032c0ace7f7af120af05; candidate036b7720c33b9e05f8984c10614a7293dc4d08e2. No dumps, runtime packages, investigation reports or images are included. No speed improvement is claimed.Checklist
main; no other open PR implements the same functions.mdfiles or images added to the repository