Repository navigation
Conversation
MarcZX10
force-pushed
the
feat/libc-memrchr
branch
2 times, most recently
from
October 8, 2026 14:09
d7c1ab6 to
4f3f2e9
Compare
MarcZX10
force-pushed
the
feat/libc-memrchr
branch
from
October 8, 2026 14:10
4f3f2e9 to
8e7a88d
Compare
6 tasks done
Collaborator
|
No title reaches |
Contributor
|
@MarcZX100 heads-up: with #1848, #2090, #1772, #1650 and #1624 merged, PICO-8 for PS5 (PPSA99808) now stops at I had #1906 for the same import; yours came first, so I'll leave it to you. If you'd rather not pick it up, let me know and I'll reopen mine. |
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implement the byte-wise reverse search used by
memrchr, including conversion of the search value tounsigned char. Add a dedicated guest test for repeated matches, bounded searches, high byte values, and misses.Tested
Linux, GCC 12.2.0:
guest_memrchrpassed; conventions check andgit diff --checkpassed.Checklist
main; no open PR implementsmemrchrGuestStrings.cppchanges in test(libc): cover strlcpy and case-insensitive comparisons #1490