Skip to content

fix(libc): export daemon - #2842

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
Get-fix:fix/libc-daemon
Oct 11, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
Get-fix:fix/libc-daemon

Conversation

@Get-fix

@Get-fix Get-fix commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

What

VLC (PPSA85300) imports daemon (Wn6I3wVATUE) and fails to load because no library exports it. It reaches this stop after execvp (#2827) and dup2 (#2478). Forking into the background is not supported, so daemon throws daemon: forking into the background not implemented. VLC 3.0 calls it only when its daemon option is set (libvlc.c), and the title starts libVLC with --ignore-config and without --daemon (player.cc). The new guest_daemon test checks the throw.

Tested

Windows 11 (WinLibs GCC 15.2.0 r7), Release, full build with BUILD_TESTING=ON on main 57f96fd:

Not tested on Linux. The same branch and results are posted in #1578.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • AI-assisted: yes (Claude Code)

🤖 Generated with Claude Code

@github-actions github-actions Bot added the intake paused Closed while PR intake is limited to authors with at least 10 PRs merged into main label Oct 10, 2026
@github-actions

Copy link
Copy Markdown

Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes.

@github-actions github-actions Bot closed this Oct 10, 2026
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Progress report (2a4e03c → 520b9fa)

📉 System libraries: 85.8% (-0.03%, +1 declared functions)

🆕 1 declared as stubs
Library Name
libc daemon_nid_postfix

@oneandonlydean oneandonlydean removed the intake paused Closed while PR intake is limited to authors with at least 10 PRs merged into main label Oct 11, 2026
@oneandonlydean

Copy link
Copy Markdown
Collaborator

Reopened. Conflict in core/libs/prx/libc/CMakeLists.txt. Can you rebase?

@github-actions github-actions Bot added needs rebase Conflicts with main, rebase needed libc build docs labels Oct 11, 2026
@babyhuey babyhuey mentioned this pull request Oct 11, 2026
9 tasks done
@adriadam10

Copy link
Copy Markdown
Collaborator

Rebased onto main (conflict with the neighbouring test block in core/libs/prx/libc/CMakeLists.txt, kept both).

Checked on Linux: guest_daemon passes; without the change it does not link (daemon_nid_postfix missing). The thrown message matches NotImplemented_nid_no_patch, and the TechnicalDebt line sits under "Functional". Merging once CI is green.

VLC (PPSA85300) imports daemon (Wn6I3wVATUE) and fails to load because
no library exports it. Forking into the background is not supported,
so it throws if called. VLC 3.0 calls daemon only when its daemon
option is set, and the title starts libVLC with --ignore-config and
without --daemon.
@adriadam10

Copy link
Copy Markdown
Collaborator

Rebased onto main again (conflict with the neighbouring guest_memrchr test block in core/libs/prx/libc/CMakeLists.txt, kept both).

Re-checked on Linux: guest_daemon passes, as do guest_memrchr and the rest of the libc/libs scope. Merging once CI is green.

@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 11, 2026
@adriadam10
adriadam10 merged commit 65a4e8e into boykopovar:main Oct 11, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants